Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dask-cloudprovider tests #3690

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

jcrist
Copy link

@jcrist jcrist commented Nov 19, 2020

The import path changed to local-only (instead of top-level) in the
latest release. Local imports are backwards compatible, so this should
work for all versions.

The import path changed to local-only (instead of top-level) in the
latest release. Local imports are backwards compatible, so this should
work for all versions.
joshmeek
joshmeek previously approved these changes Nov 19, 2020
@joshmeek joshmeek dismissed their stale review November 19, 2020 21:36

Nvm it's failing :(

@jcrist
Copy link
Author

jcrist commented Nov 19, 2020

Yeah, looks like a bad changelog entry was merged in a prior PR (also needed to update the requirements to include AWS extra).

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #3690 (784b73c) into master (dacfb9c) will not change coverage.
The diff coverage is n/a.

@joshmeek joshmeek merged commit 27ea596 into PrefectHQ:master Nov 19, 2020
@jcrist jcrist deleted the fix-dask-cloudprovider-tests branch November 19, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants