Dremio task #3734
Merged
Dremio task #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here I am, brain the size of a planet and they ask me to welcome you to Prefect. So, welcome to the community @strojank! 🎉 🎉 |
|
Hey @strojank would you mind merging the latest from master into your branch? We just merged in a PR that fixes some of the issues we have been seeing in the CI tests! |
joshmeek
reviewed
Dec 1, 2020
Comment on lines
+59
to
+62
| self.user = user | ||
| self.password = password | ||
| self.host = host | ||
| self.port = port |
There was a problem hiding this comment.
I think all of these kwargs should also be allowed at runtime and in the defaults_from_attrs (like you do with query) because then they can be specified using upstream PrefectSecret tasks 🙂
There was a problem hiding this comment.
Thanks, that makes sense. Kwargs added :)
joshmeek
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates a starting point for Dremio-related tasks.
Changes
It adds a task for fetching data with Dremio using Arrow Flight.
Importance
It expands Prefect task library.
Checklist
This PR:
changes/directory (if appropriate)docs/outline.tomlfor API reference docs (if appropriate)