-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EmailTask: accept msg_plain, email_to_cc and email_to_bcc #4157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @joelluijmes, this is a nice upgrade for this task! Can you confirm that switching to this different email API isn't going to break anything for existing users?
Yes should be backwards compatible. As in, didn’t rename the param or changed the order :) |
My concern is that the appearance of people's emails will change since the content is being specified differently now and I don't want to break anyone's flows using email tasks. |
Understandably, but fortunately this doesn't change anything. Only specifiying the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you merge master
in you'll fix the codecov error. You'll need to run black
on whatever file it's complaining about. Otherwise this LGTM, I like the rephrased comment 👍
Summary
Expends possibilities of
EmailTask
by accepting the following parameters: msg_plain, email_to_cc and email_to_bccmsg_plain
: allows to add plain text version of emailemail_to_cc
: additional addresses to put in CCemail_to_bcc
: additional addresses to put in BCCChanges
Additional parameters.
Importance
More flexibility :)
Checklist
This PR:
changes/
directory (if appropriate)docs/outline.toml
for API reference docs (if appropriate)