Fix ShellTask on win32
#4397
Merged
Fix ShellTask on win32
#4397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows, the single `\` in the path disappears when evaluated by bash so we need to have double `\\` in the string written to the file.
zanieb
changed the title
ShellTaskShellTask to be used on win32
zanieb
changed the title
ShellTask to be used on win32ShellTask on win32
zangell44
approved these changes
Apr 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
ShellTaskdoes not work on win32 because it does not look for executables in the path by default. This setsPopen(..., shell=True)when using win32 which inspects the path for the given executable.You still need
bashinstalled and on yourPATHfor this to work by default. Other shells should work without issue as well, butcmd.exedoes not seem to support running a script.Importance
Closes #1984 #4393
Checklist
This PR:
changes/directory (if appropriate)docs/outline.tomlfor API reference docs (if appropriate)