Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big query insert #685

Merged
merged 6 commits into from
Feb 26, 2019
Merged

Big query insert #685

merged 6 commits into from
Feb 26, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Feb 25, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

What does this PR change?

Adds a new task to the task library for inserting rows into BigQuery tables.

Copy link
Member

@jlowin jlowin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. My only thought is that because this is a BigQuery streaming insert, not an insert DML statement as some might suspect, we should maybe rename the task BigQueryStreamingInsertTask (or similar) to make that clear. Right now the only distinction is the docstring.

This has a larger consequence than just naming because Google charges for streaming inserts, so users should prefer DML or bulk uploads unless they need real-time availability. We could create a separate BigQueryInsertTask that uploaded results from a file (for free).

@cicdw
Copy link
Member Author

cicdw commented Feb 26, 2019

Very good point; updated.

@cicdw cicdw merged commit cf61410 into master Feb 26, 2019
@cicdw cicdw deleted the big-query-insert branch February 26, 2019 15:00
@bnaul bnaul mentioned this pull request Jul 18, 2019
cicdw pushed a commit that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants