Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes Tasks #779

Merged
merged 25 commits into from
Mar 21, 2019
Merged

Kubernetes Tasks #779

merged 25 commits into from
Mar 21, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Mar 21, 2019 •
edited
Loading

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

What does this PR change?

Adds Kubernetes tasks to the task library. Currently supporting create, delete, list, patch, read, and replace for deployments, jobs, pods, and services.

Closes #736 but adds much, much more

Why is this PR important?

So we have built in ways of orchestrating Kubernetes with Prefect

@joshmeek joshmeek added the integrations Related to integrations with other services label Mar 21, 2019
cicdw
cicdw requested changes Mar 21, 2019
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some docstrings comments mainly, and one about assigning to self within run. This PR is super. great.

CHANGELOG.md Show resolved Hide resolved
src/prefect/tasks/kubernetes/deployment.py Outdated Show resolved Hide resolved
src/prefect/tasks/kubernetes/deployment.py Outdated Show resolved Hide resolved
src/prefect/tasks/kubernetes/deployment.py Outdated Show resolved Hide resolved
src/prefect/tasks/kubernetes/deployment.py Outdated Show resolved Hide resolved
src/prefect/tasks/kubernetes/deployment.py Show resolved Hide resolved
cicdw
cicdw approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beast mode

@joshmeek joshmeek merged commit 88e627b into master Mar 21, 2019
@joshmeek joshmeek deleted the kube_tasks branch March 21, 2019 22:36
zanieb added a commit that referenced this pull request Jan 12, 2022
@zanieb
Merge pull request #779 from PrefectHQ/deployment-run
b36d0af 
Move `prefect flow-run create` to `prefect deployment run`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@jlowin jlowin Awaiting requested review from jlowin

Assignees
No one assigned
Labels
integrations Related to integrations with other services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshmeek @cicdw