Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jitter to task run submission based on number of in-flight submissions #8914

Closed
wants to merge 1 commit into from
Closed

Add jitter to task run submission based on number of in-flight submissions #8914

wants to merge 1 commit into from

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Mar 23, 2023

Alternative approach to #8913

@zanieb zanieb added the enhancement An improvement of an existing feature label Mar 23, 2023
@netlify
Copy link

netlify bot commented Mar 23, 2023 •
edited
Loading

✅ Deploy Preview for prefect-docs ready!

Name Link
🔨 Latest commit 938b2a3
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs/deploys/641ccadf424d8b000842aea8
😎 Deploy Preview https://deploy-preview-8914--prefect-docs.netlify.app/api-ref/prefect/engine
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 23, 2023
View reviewed changes
src/prefect/engine.py
@@ -1216,6 +1226,8 @@
task_runner=task_runner,
)

_inflight_task_submissions -= 1

Check notice

Code scanning / CodeQL

Unused global variable

The global variable '_inflight_task_submissions' is not used.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not...?

@github-actions
Copy link
Contributor

This pull request is stale because it has been open 60 days with no activity. To keep this pull request open remove stale label or comment.

@zanieb zanieb closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw Awaiting requested review from cicdw cicdw will be requested when the pull request is marked ready for review cicdw is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle will be requested when the pull request is marked ready for review desertaxle is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz will be requested when the pull request is marked ready for review zzstoatzz is a code owner

Assignees
No one assigned
Labels
enhancement An improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zanieb