Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the core version in the sidebar #431

Merged
merged 11 commits into from
Nov 19, 2020
Merged

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Nov 11, 2020

☁️ This feature cannot be merged until core_version is in prod. See tracking

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Adds the core version from PrefectHQ/server#126 to the state and displays it in the sidebar under the Prefect logo

Screen Shot 2020-11-12 at 1 40 30 PM

Notes:

  • The core version will only display for Server because it is not meaningful from Cloud
  • For sanctioned versions, the +... commits ahead of master cruft should not be there but a release of Server needs to be cut for me to show it a screenshot

@zanieb zanieb marked this pull request as ready for review November 12, 2020 21:46
@zanieb
Copy link
Contributor Author

zanieb commented Nov 12, 2020

Closes PrefectHQ/server#120

Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @madkinsz - @znicholasbrown anything to add or shall we merge?

@zanieb
Copy link
Contributor Author

zanieb commented Nov 16, 2020

Nothing more from me!

@znicholasbrown
Copy link
Contributor

We'll wait until the next Core release to merge to make sure this doesn't break Prefect-hosted but Server-backed setups.

@znicholasbrown
Copy link
Contributor

This should be good to go with the release of 0.13.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants