0005 - Add ADR about access rules for Symfony controllers #1
Conversation
| ## Consequences | ||
|
|
||
| We need to update all controllers already built so they follow this rule. | ||
| We need to make sure controllers that will be added will follow this rule. |
There was a problem hiding this comment.
This should be reflected in an issue in the prestashop specs repository and linked here.
There was a problem hiding this comment.
An issue, specs are to be written by @PrestaShop/prestashop-product-team
There was a problem hiding this comment.
@matks @eternoendless We need more information and context to be able to write specs
There was a problem hiding this comment.
That information should be provided in said issue 🙂
|
0001 should be in a separate PR, shouldn't it? |
matks
force-pushed
the
add-ADR-about-access-rules-for-sf-controllers
branch
from
a46cdc7
to
fc12af9
Compare
|
PR updated with feedbacks handled |
| ## Consequences | ||
|
|
||
| We need to update all controllers already built so they follow this rule. | ||
| We need to make sure controllers that will be added will follow this rule. |
There was a problem hiding this comment.
| We need to make sure controllers that will be added will follow this rule. | |
| We need to make sure controllers that will be added will follow this rule (see [issue](https://github.com/PrestaShop/prestashop-specs/issues/1)). |
| We need to update all controllers already built so they follow this rule. | ||
| We need to make sure controllers that will be added will follow this rule. | ||
|
|
||
| See issue https://github.com/PrestaShop/PrestaShop/issues/12270 |
There was a problem hiding this comment.
| See issue https://github.com/PrestaShop/PrestaShop/issues/12270 |
| We need to make sure controllers that will be added will follow this rule. | ||
|
|
||
| See issue https://github.com/PrestaShop/PrestaShop/issues/12270 | ||
| See specs https://github.com/PrestaShop/prestashop-specs/issues/1 |
There was a problem hiding this comment.
| See specs https://github.com/PrestaShop/prestashop-specs/issues/1 |
…define-acl-rules-for-symfony-pages.md
eternoendless
changed the title
|
ADR process is heavy and costly so I close this PR as the cost/benefit factor is not high enough. |
No description provided.