post review fixes

package.json

@@ -10,4 +10,4 @@
     },
     "author": "PrestaShop",
     "license": "OSL-3.0"
-}
+}

src/Adapter/Presenter/Module/ModulePresenter.php

@@ -26,8 +26,10 @@
 namespace PrestaShop\PrestaShop\Adapter\Presenter\Module;
 
 use Currency;
+use PrestaShop\PrestaShop\Adapter\Module\Module;
 use PrestaShop\PrestaShop\Adapter\Product\PriceFormatter;
 use PrestaShop\PrestaShop\Adapter\Presenter\PresenterInterface;
+use Exception;
 
 class ModulePresenter implements PresenterInterface
 {
@@ -52,8 +54,8 @@ public function __construct(Currency $currency, PriceFormatter $priceFormatter)
      */
     public function present($module)
     {
-        if (!is_a($module, '\\PrestaShop\\PrestaShop\\Adapter\\Module\\Module')) {
-            throw new \Exception("ModulePresenter can only present instance of Module");
+        if (!($module instanceof Module)) {
+            throw new Exception("ModulePresenter can only present instance of Module");
         }
 
         $attributes = $module->attributes->all();

src/Adapter/Presenter/Object/ObjectPresenter.php

@@ -28,19 +28,21 @@
 
 use Hook;
 use PrestaShop\PrestaShop\Adapter\Presenter\PresenterInterface;
+use ObjectModel;
+use Exception;
 
 class ObjectPresenter implements PresenterInterface
 {
     /**
-     * @param \ObjectModel $object
+     * @param ObjectModel $object
      *
      * @return array
-     * @throws \Exception
+     * @throws Exception
      */
     public function present($object)
     {
-        if (!is_a($object, 'ObjectModel')) {
-            throw new \Exception('ObjectPresenter can only present ObjectModel classes');
+        if (!($object instanceof ObjectModel)) {
+            throw new Exception('ObjectPresenter can only present ObjectModel classes');
         }
 
         $presentedObject = array();
@@ -49,10 +51,7 @@ public function present($object)
         foreach ($fields as $fieldName => $null) {
             $presentedObject[$fieldName] = $object->{$fieldName};
         }
-        $mustHave = ['id'];
-        foreach ($mustHave as $fieldName) {
-            $presentedObject[$fieldName] = $object->{$fieldName};
-        }
+        $presentedObject['id'] = $object->id;
 
         $mustRemove = ['deleted', 'active'];
         foreach ($mustRemove as $fieldName) {

src/Adapter/Presenter/Order/OrderDetailLazyArray.php

@@ -51,7 +51,7 @@ class OrderDetailLazyArray extends AbstractLazyArray
     /**
      * OrderDetailLazyArray constructor.
      */
-    public function __construct($order)
+    public function __construct(Order $order)
     {
         $this->order = $order;
         $this->context = Context::getContext();

src/Adapter/Presenter/Order/OrderLazyArray.php

@@ -78,7 +78,7 @@ class OrderLazyArray extends AbstractLazyArray
      * @throws AnnotationException
      * @throws ReflectionException
      */
-    public function __construct($order)
+    public function __construct(Order $order)
     {
         $this->order = $order;
         $this->cartPresenter = new CartPresenter();

src/Adapter/Presenter/Order/OrderPresenter.php

@@ -41,8 +41,8 @@ class OrderPresenter implements PresenterInterface
      */
     public function present($order)
     {
-        if (!is_a($order, 'Order')) {
-            throw new Exception('OrderArray can only present instance of Order');
+        if (!($order instanceof Order)) {
+            throw new Exception('OrderPresenter can only present instance of Order');
         }
 
         return new OrderLazyArray($order);

src/Adapter/Presenter/Order/OrderSubtotalLazyArray.php

@@ -61,7 +61,7 @@ class OrderSubtotalLazyArray extends AbstractLazyArray
     /**
      * OrderSubtotalLazyArray constructor.
      */
-    public function __construct($order)
+    public function __construct(Order $order)
     {
         $this->context = Context::getContext();
         $this->taxConfiguration = new TaxConfiguration();
@@ -99,7 +99,7 @@ public function getDiscounts()
         $discountAmount = ($this->includeTaxes)
             ? $this->order->total_discounts_tax_incl
             : $this->order->total_discounts_tax_excl;
-        if ((float) $discountAmount) {
+        if ($discountAmount) {
             return array(
                 'type' => 'discount',
                 'label' => $this->translator->trans('Discount', array(), 'Shop.Theme.Checkout'),
@@ -156,7 +156,7 @@ public function getShipping()
     public function getTax()
     {
         $tax = $this->order->total_paid_tax_incl - $this->order->total_paid_tax_excl;
-        if ((float) $tax && Configuration::get('PS_TAX_DISPLAY')) {
+        if ($tax && Configuration::get('PS_TAX_DISPLAY')) {
             return array(
                 'type' => 'tax',
                 'label' => $this->translator->trans('Tax', array(), 'Shop.Theme.Checkout'),