Merge pull request #17434 from PierreRambaud/update/eslint-directories

Update eslint config to check for hidden directories and files

admin-dev/themes/new-theme/.eslintignore

@@ -2,3 +2,5 @@
 /public/
 /bundle.js
 /tests/
+!.eslintrc.js
+!.webpack

admin-dev/themes/new-theme/.eslintrc.js

@@ -19,35 +19,44 @@ module.exports = {
   },
   extends: [
     'prestashop',
-    'plugin:vue/strongly-recommended'
+    'plugin:vue/strongly-recommended',
   ],
   plugins: [
     'import',
     'vue',
   ],
   rules: {
-    'no-new': 0,
+    'class-methods-use-this': 0,
     'func-names': 0,
+    'import/no-extraneous-dependencies': [
+      'error',
+      {
+        devDependencies: [
+          'tests/**/*.js',
+          '.webpack/**/*.js',
+        ],
+      },
+    ],
+    'max-len': ['error', {code: 120}],
     'no-alert': 0,
     'no-bitwise': 0,
-    'class-methods-use-this': 0,
-    'max-len': ['error', { code: 120 }],
-    'no-param-reassign': ['error', { props: false }],
-    'prefer-destructuring': ['error', {object: true, array: false}],
+    'no-new': 0,
+    'no-param-reassign': ['error', {props: false}],
     'no-restricted-globals': [
       'error',
       {
         name: 'global',
         message: 'Use window variable instead.',
       },
     ],
+    'prefer-destructuring': ['error', {object: true, array: false}],
     'vue/script-indent': [
       'error',
       2,
       {
         baseIndent: 1,
         switchCase: 1,
-      }
+      },
     ],
   },
   settings: {

admin-dev/themes/new-theme/.webpack/common.js

@@ -22,13 +22,11 @@
  * @license   https://opensource.org/licenses/OSL-3.0 Open Software License (OSL 3.0)
  * International Registered Trademark & Property of PrestaShop SA
  */
-const fs = require('fs');
 const path = require('path');
 const webpack = require('webpack');
 const CleanWebpackPlugin = require('clean-webpack-plugin');
 const CopyPlugin = require('copy-webpack-plugin');
 const ExtractTextPlugin = require('extract-text-webpack-plugin');
-const cssExtractedFileName = 'theme';
 
 module.exports = {
   externals: {
@@ -231,15 +229,15 @@ module.exports = {
     new ExtractTextPlugin('theme.css'),
     new CleanWebpackPlugin(['public'], {
       root: path.resolve(__dirname, '../'),
-      exclude: ['theme.rtlfix']
+      exclude: ['theme.rtlfix'],
     }),
     new webpack.ProvidePlugin({
       moment: 'moment', // needed for bootstrap datetime picker
       $: 'jquery', // needed for jquery-ui
       jQuery: 'jquery',
     }),
     new CopyPlugin([
-      { from: 'static' },
-    ])
+      {from: 'static'},
+    ]),
   ],
 };

admin-dev/themes/new-theme/.webpack/dev.js

@@ -6,7 +6,7 @@ const common = require('./common.js');
  * by merging development specific configuration with the common one.
  */
 function devConfig() {
-  let dev = Object.assign(
+  const dev = Object.assign(
     common,
     {
       devtool: 'inline-source-map',
@@ -15,7 +15,7 @@ function devConfig() {
         contentBase: path.resolve(__dirname, '/../public'),
         publicPath: '/',
       },
-    }
+    },
   );
 
   return dev;

admin-dev/themes/new-theme/.webpack/prod.js

@@ -1,40 +1,38 @@
-const common = require('./common.js');
 const webpack = require('webpack');
 const keepLicense = require('uglify-save-license');
+const common = require('./common.js');
 
 /**
  * Returns the production webpack config,
  * by merging production specific configuration with the common one.
- *
- * @param {Boolean} analyze If true, bundle analyze plugin will launch
  */
-function prodConfig(analyze) {
-  let prod = Object.assign(
+function prodConfig() {
+  const prod = Object.assign(
     common,
     {
       stats: 'minimal',
-    }
+    },
   );
 
   prod.plugins.push(
     new webpack.optimize.UglifyJsPlugin({
       sourceMap: true,
       uglifyOptions: {
         compress: {
-          drop_console: true
+          drop_console: true,
         },
         output: {
-          comments: keepLicense
-        }
+          comments: keepLicense,
+        },
       },
-    })
+    }),
   );
 
   // Required for Vue production environment
   prod.plugins.push(
     new webpack.DefinePlugin({
-      'process.env.NODE_ENV': JSON.stringify('production')
-    })
+      'process.env.NODE_ENV': JSON.stringify('production'),
+    }),
   );
 
   return prod;

admin-dev/themes/new-theme/webpack.config.js

@@ -27,7 +27,6 @@
 /**
  * Three mode available:
  *  build = production mode
- *  build:analyze = production mode with bundler analyzer
  *  dev = development mode
  */
 const prod = require('./.webpack/prod.js');