Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint config to check for hidden directories and files #17434

Merged
merged 1 commit into from Jan 31, 2020
Merged

Update eslint config to check for hidden directories and files #17434

merged 1 commit into from Jan 31, 2020

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Jan 30, 2020 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Hidden directories and files are ignored by default. Add them in .eslintignore following the eslint configuration https://github.com/eslint/eslint/blob/master/.eslintignore#L12. Also add a rule to don't force dependencies to be added in "dependencies" when it's only related to the "devDependencies"
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? Travis and tests must be green, no need QA.

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.8.0 milestone Jan 30, 2020
@PierreRambaud PierreRambaud requested a review from a team as a code owner January 30, 2020 13:09
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Jan 30, 2020
NeOMakinG
NeOMakinG previously approved these changes Jan 30, 2020
View reviewed changes
Copy link

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PierreRambaud PierreRambaud changed the title Update eslint config to check for hidden directories Update eslint config to check for hidden directories and files Jan 30, 2020
Progi1984
Progi1984 previously approved these changes Jan 31, 2020
View reviewed changes
jolelievre
jolelievre previously approved these changes Jan 31, 2020
View reviewed changes
@matks
Copy link
Contributor

matks commented Jan 31, 2020

Thank you @PierreRambaud

@matks matks merged commit e91fcec into PrestaShop:develop Jan 31, 2020
@PierreRambaud PierreRambaud deleted the update/eslint-directories branch April 26, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

@jolelievre jolelievre Awaiting requested review from jolelievre

@NeOMakinG NeOMakinG Awaiting requested review from NeOMakinG

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@PierreRambaud @matks @Progi1984 @jolelievre @NeOMakinG @prestonBot