-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish Migrating "Catalog > Attributes & Features > Add new / edit attribute Group" page #10508
Closed
5 of 7 tasks
Labels
Attributes
Label: Which BO under menu is concerned
BO
Category: Back Office
Feature
Type: New Feature
migration
symfony migration project
PR available
Solution: issue is being addressed
Projects
Comments
Check-List (copied from #13989) to help verify new Symfony page is readyController / template
Conventions
Core
Conventions
Polishing
Testing
*Eligible = easy to isolate and unit tests provide values (for example testing getters/setters is useless) |
5 tasks
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Attributes
Label: Which BO under menu is concerned
BO
Category: Back Office
Feature
Type: New Feature
migration
symfony migration project
PR available
Solution: issue is being addressed
Part of Symfony migration project
Status
In order to finish the migration of this back-office page, we need to:
Todo List:
About PR #31502
The PR #31502 aimed to create a new Symfony backoffice page to replace the legacy page "Catalog > Attributes & Features > Add new / edit attribute Group". The new Symfony page should follow the coding standards we have for all Symfony pages while providing the same behavior that the legacy page. It aims to create an equivalent page, but powered by Symfony and Twig :) .
Just like other Symfony pages, the application layer is Symfony + Twig, but it uses Commands and Queries to fetch and modify data. Command and Query Handlers are adapters that do rely on legacy.
What you must do for PR #31502 is to fetch it
About the last PR
First Todo List items will be done by multiple PRs merged into
develop
. So the work of "create a new Symfony page that provides the same behavior/features as the legacy page" will be carried out BUT it is done on a Symfony page not accessible yet in the backoffice. You can browse it if you know the URL. It's like it's hidden.In order to "finish" the job, a last PR is needed: this is the PR which removes legacy files and enables the LegacyLinks that will redirect old URLs to the new page. So the new Symfony page replaces the legacy page in the back-office. When this is done, the migration is complete.
It is possible QA will find problems when testing the last PR: behaviors that used to work with the legacy page and are not working / implemented in the Symfony page. Then you must fix them.
Please ask @MatShir if you have questions about the behavior or @matks if you have questions about the code
The text was updated successfully, but these errors were encountered: