-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish Migrating Catalog > Attributes & Features > Attribute Group > Add / edit attribute value #33126
Closed
1 of 5 tasks
Labels
Attributes
Label: Which BO under menu is concerned
Feature
Type: New Feature
migration
symfony migration project
PR available
Solution: issue is being addressed
Ready
Status: Issue is ready to be worked on
Projects
Comments
MatShir
added
Feature
Type: New Feature
Attributes
Label: Which BO under menu is concerned
migration
symfony migration project
Ready
Status: Issue is ready to be worked on
labels
Jul 6, 2023
matks
changed the title
Catalog > Attributes & Features > Attribute Group > Add / edit attribute value
Finish Migrating Catalog > Attributes & Features > Attribute Group > Add / edit attribute value
Jul 27, 2023
This was referenced Jul 27, 2023
Closed
Check-List (copied from #13989) to help verify new Symfony page is readyController / template
Conventions
Core
Conventions
Polishing
Testing
*Eligible = easy to isolate and unit tests provide values (for example testing getters/setters is useless) |
Not the priority for the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Attributes
Label: Which BO under menu is concerned
Feature
Type: New Feature
migration
symfony migration project
PR available
Solution: issue is being addressed
Ready
Status: Issue is ready to be worked on
Part of Symfony migration project
Status
In order to finish the migration of this back-office page, we need to:
Todo List:
Unblocking #32475
While working on PR #32475, it was found that a bug in blockwishlist module creates a problem. According to this comment, an exception is thrown when the BO user attempts to delete a Attribute value.
So we cannot migrate the page without fixing this bug in blockwishlist module!
A PR to fix blockwishlist module was submitted here PrestaShop/blockwishlist#226 BUT it could not be tested by QA. This is because when QA team attempts to verify the PR, their tests are hindered by the bug #32844 . The bug #32844 prevents the PR to be validated.
So to sum up, in order to unblock PR #32745
wishlist-button-add
& the list ofMy wishlists
are not displayed on dev branch #32844 ondev
branch of blockwishlist moduledevelop
branch of the Core (please submit a PR to update the composer.lock) so PR Migrating attribute value page #32475 is unblocked 🎉About PR #32475
The PR #32475 aimed to create a new Symfony backoffice page to replace the legacy page "Catalog > Attributes & Features > Add new / edit attribute Group". The new Symfony page should follow the coding standards we have for all Symfony pages while providing the same behavior that the legacy page. It aims to create an equivalent page, but powered by Symfony and Twig :) .
Just like other Symfony pages, the application layer is Symfony + Twig, but it uses Commands and Queries to fetch and modify data. Command and Query Handlers are adapters that do rely on legacy.
What you must do for PR #32475 is to fetch it
About the last PR
First Todo List items will be done by multiple PRs merged into
develop
. So the work of "create a new Symfony page that provides the same behavior/features as the legacy page" will be carried out BUT it is done on a Symfony page not accessible yet in the backoffice. You can browse it if you know the URL. It's like it's hidden.In order to "finish" the job, a last PR is needed: this is the PR which removes legacy files and enables the LegacyLinks that will redirect old URLs to the new page. So the new Symfony page replaces the legacy page in the back-office. When this is done, the migration is complete.
It is possible QA will find problems when testing the last PR: behaviors that used to work with the legacy page and are not working / implemented in the Symfony page. Then you must fix them.
Please ask @MatShir if you have questions about the behavior or @matks if you have questions about the code
The text was updated successfully, but these errors were encountered: