Migrate "Shipping > Carriers > Add new / edit carrier" page

[matks]

Part of Symfony migration project
Type: page

Status

Todo:

• Create "add carrier" command [On pause] Create AddCarrierCommand and cover with tests #14551
• At each save make sure there is data modification before for saving a new carrier in the database
• https://docs.prestashop-project.org/functional-documentation/functional-documentation/ux-ui/back-office/improve/shipping/carrier
• https://www.figma.com/file/QlgjdPJHkpTZ8NSgLa4qzr/Carrier-page?type=design&node-id=0%3A1&mode=design&t=VLVfvOOawEK9yXvJ-1 mock up with new feature ideas
• Migrate form rendering [On pause] Migrate carrier create/edit form rendering #14397
• Improve wording Migrate "Shipping > Carriers > Add new / edit carrier" page #10586
• Fix old bugs (see below)
• Multistore header: specs

Old bugs:

• Delivery price cannot be defined by shop #10384
• After Enabling "Free shipping" in the carriers page => the ranges shouldn't be emptied #15214

Check-List (copied from #13989)

App layer

Controller / routing

• All controller actions are migrated and protected with @AdminSecurity annotations when eligible and @DemoRestricted annotations when eligible
• All links targeting this page are updated: either using _legacy_link or updating the code
• The new SF routes have _legacy_link and _legacy_parameters provided and explained
• Controller catches Domain Exception and translate them nicely
• Add/Edit controllers must catch global Exception in order to handle ModuleErrorException

Template

• Twig templates must contain relevant blocks to allow partial extension by modules
• Twig forms must have form_rest() and form_errors()
• JS being used on the page can be used as enabled extensions and use a PageMap for selectors
• Use @PrestaShop instead of PrestaShopBundle for template root path aliasing

Conventions

• The new controller actions comply with our naming convention
• The new SF routes names and paths comply with our naming convention
• The new Twig template names comply actions with our naming convention
• Created files (controller, JS assets, CSS assets and twig views) must be in the right folder following the convention
• CSS being added must follow theme conventions

Core layer

• Commands and Queries only use native types but internally use VOs
• All Handlers must have an Interface

Conventions

• The created SF service names comply with our naming convention
• The created files must follow the folder convention (Domain, Core, Adapter...)

Polishing

• The legacy controller and templates files are gone
• If PR includes a new concept/mechanism, documentation must be written
• JS and CSS assets must be compiled and up-to-date
• License headers must be up-to-date
• New hooks have been added to the hooks list and the SQL updates
• Performance must be correct: page loading time, filtering/sorting/searching response time, actions response time

Testing

• Commands and Queries are tested with Behat tests
• Eligible Core classes are covered with unit tests*
• Controller is covered with survival test
• (soon) Controller is covered with E2E tests using puppeeter
• If we break E2E tests because IDs change, we must update the E2E tests

*Eligible = easy to isolate and unit tests provide values (for example testing getters/setters is useless)

[eternoendless]

We should investigate this issue when we start working on this page: #10384

[zuk3975]

@matks, should the carriers form be powered by some kind of vue component that would be used in products page (as suggested for products page at #14492)?

[matks]

#14492

After diving further, we have decided not to use vue.js for the Product Page, we will rely on good old jQuery in order to make the page as customizable as possible.

I think the answer is valid for this page too :/ jQuery it is !

[rblaurin]

Hi
Isn't it going to be ready for 1.7.7 anymore?

Thanks!

[matks]

Hi
Isn't it going to be ready for 1.7.7 anymore?

Thanks!

Probably not, all of our energy right now is focused on Orders pages (listing, create, view)

[matks]

PR started but not finished #14551

[matks]

Another PR on the topic #14397