Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to don't add anchor in the URL for getProductLink method #22223

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Be able to don't add anchor in the URL for getProductLink method #22223

merged 4 commits into from
Jan 12, 2021

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Dec 3, 2020

Questions Answers
Branch? develop
Description? We should be able to remove the anchor in the URL.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11041
How to test? Follow ticket instruction. QA can be done by a dev. {url id="1" ipa=1 entity="product" add_anchor=true with_id_in_anchor=true}

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from a team as a code owner December 3, 2020 15:51
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Dec 3, 2020
Progi1984
Progi1984 previously approved these changes Dec 3, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Dec 3, 2020
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like Phpstan is unhappy, but it doesn't seem to be related to your PR

@matthieu-rolland matthieu-rolland added the Waiting for QA Status: action required, waiting for test feedback label Dec 3, 2020
@PierreRambaud PierreRambaud added the Waiting for dev Status: action required, waiting for tech feedback label Dec 3, 2020
@atomiix
Copy link
Contributor

atomiix commented Dec 17, 2020

@PierreRambaud Maybe I misunderstood the original issue but as there is no change in the Link::getUrlSmarty() function, when using the {url} helper, the new parameter cannot be took into account.

@atomiix atomiix closed this Dec 17, 2020
@atomiix atomiix reopened this Dec 17, 2020
@PierreRambaud
Copy link
Contributor Author

@PierreRambaud Maybe I misunderstood the original issue but as there is no change in the Link::getUrlSmarty() function, when using the {url} helper, the new parameter cannot be took into account.

You're totally right, didn't check the issue, just follow what @kpodemski did 😅
I update my pull request and the how-to test part.

classes/Link.php Outdated Show resolved Hide resolved
@kpodemski
Copy link
Contributor

nice catch @atomiix

@NeOMakinG
Copy link

NeOMakinG commented Jan 12, 2021

Hey

Without anchor and id :
image

With anchor only :
image

With anchor and ID :
image

Thanks @PierreRambaud

@NeOMakinG NeOMakinG added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback Waiting for dev Status: action required, waiting for tech feedback labels Jan 12, 2021
@Progi1984 Progi1984 merged commit 6f490a7 into PrestaShop:develop Jan 12, 2021
@Progi1984
Copy link
Member

Thanks @PierreRambaud & @NeOMakinG

@PierreRambaud PierreRambaud deleted the fix/11041 branch May 26, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to remove anchor from product link when using URL smarty helper function
7 participants