-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be able to don't add anchor in the URL for getProductLink method #22223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like Phpstan is unhappy, but it doesn't seem to be related to your PR
@PierreRambaud Maybe I misunderstood the original issue but as there is no change in the |
b8ffdc7
You're totally right, didn't check the issue, just follow what @kpodemski did 😅 |
nice catch @atomiix |
Hey Thanks @PierreRambaud |
Thanks @PierreRambaud & @NeOMakinG |
{url id="1" ipa=1 entity="product" add_anchor=true with_id_in_anchor=true}
This change is