Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting show_price to off doesn't hide price in schema.org tags #11844

Closed
kpodemski opened this issue Dec 19, 2018 · 1 comment
Closed

Setting show_price to off doesn't hide price in schema.org tags #11844

kpodemski opened this issue Dec 19, 2018 · 1 comment
Labels
1.7.4.4 Affects versions 1.7.5.0 Affects versions Bug Type: Bug Fixed Resolution: issue closed because fixed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Old Products Page Concerns the old product page
Milestone

Comments

@kpodemski
Copy link
Contributor

Describe the bug

If you don't want to show prices in products, for eg. by setting show_price to No or hide prices for Group, it does not hide prices in schema.org tags

To Reproduce
Steps to reproduce the behavior:

  1. Go to whatever Product you want and edit it
  2. Turn on catalog mode and turn off showing price
  3. Now save changes, visit product page and check source code of the page, you'll see:
<meta property="product:pretax_price:amount" content="35.9">
<meta property="product:pretax_price:currency" content="PLN">
<meta property="product:price:amount" content="44.16">
<meta property="product:price:currency" content="PLN">

even tho price should be not visible

Additionnal information
PrestaShop version: 1.7.4.4
PHP version: 7.0

@khouloudbelguith
Copy link
Contributor

Hi @kpodemski,

Thanks for your report.
I manage to reproduce the issue with the last version PrestaShop v1.7.5.0
I disabled show price in the customer Group page for all group.
When I check the source code of the product page, the price is visible.
image
We will see how to fix it.
Thanks!

@khouloudbelguith khouloudbelguith added Bug Type: Bug Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Old Products Page Concerns the old product page 1.7.5.0 Affects versions 1.7.4.4 Affects versions Ready Status: Issue is ready to be worked on labels Dec 19, 2018
@ntiepresta ntiepresta added Fixed Resolution: issue closed because fixed and removed Ready Status: Issue is ready to be worked on labels Jan 31, 2019
@khouloudbelguith khouloudbelguith added this to the 1.7.6.0 milestone Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.4.4 Affects versions 1.7.5.0 Affects versions Bug Type: Bug Fixed Resolution: issue closed because fixed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Old Products Page Concerns the old product page
Projects
None yet
Development

No branches or pull requests

3 participants