Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two timezones pacific in installer #14411

Closed
Tracked by #22664
marionf opened this issue Jun 28, 2019 · 5 comments · Fixed by PrestaShop/autoupgrade#507 or #29664
Closed
Tracked by #22664

Two timezones pacific in installer #14411

marionf opened this issue Jun 28, 2019 · 5 comments · Fixed by PrestaShop/autoupgrade#507 or #29664
Assignees
@Progi1984
Labels
1.7.5.2 Affects versions Bug Type: Bug Fixed Resolution: issue closed because fixed Good first issue Community: beginner-friendly issues IN Category: Install PM ✔️ Status: check done, behavior approved PR available Solution: issue is being addressed Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification Verified The issue has been reproduced
Milestone
8.1.0

Comments

@marionf
Copy link
Contributor

marionf commented Jun 28, 2019 •
edited by LouiseBonnard
Loading

Describe the bug
2 timezones pacific in installer

To Reproduce
Steps to reproduce the behavior:

  1. Install PS in English + United States

This is the norme for US:

install 3

Screenshots
install 2

Specifications
US/Pacific New is an obsolete timezone that should not be displayed nor selected by users in the PrestaShop installer, therefore it should be removed. Currently, it appears in the following files:

  • install-dev/data/xml/timezone.xml
  • install-dev/upgrade/sql/1.2.0.2.sql
  • install-dev/upgrade/sql/1.2.0.1.sql

Additionnal information
PrestaShop version: 1.7.5, 1.7.6
PHP version: N/A
@marionf marionf added Bug Type: Bug IN Category: Install Ready Status: Issue is ready to be worked on Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification 1.7.5.2 Affects versions 1.7.6.0 Affects versions labels Jun 28, 2019
@colinegin
Copy link

What do you think of this issue @LouiseBonnard ?

@LouiseBonnard
Copy link
Contributor

US/Pacific-New is an obsolete timezone, therefore it should not be available in this drop-down list. More info here. I suppose that timezones in PrestaShop are introduced by a protocol - IANA, perhaps.

@PrestaShop/prestashop-core-developers, would it be safe to remove the mention of this obsolete timezone in install-dev/data/xml/timezone.xml?

Also, I can see that it is also mentioned in the following files (related to databases if I'm right):

install-dev/upgrade/sql/1.2.0.2.sql
install-dev/upgrade/sql/1.2.0.1.sql

@LouiseBonnard LouiseBonnard self-assigned this Feb 3, 2020
@LouiseBonnard LouiseBonnard added the Waiting for dev Status: action required, waiting for tech feedback label Apr 24, 2020
@PierreRambaud
Copy link
Contributor

Yes it is safe, we can remove whatever we want for timezone :)

@PierreRambaud PierreRambaud removed the Waiting for dev Status: action required, waiting for tech feedback label Nov 20, 2020
@LouiseBonnard
Copy link
Contributor

It's great news, thanks @PierreRambaud, let's remove the obsolete timezone US/Pacific-New then!

@LouiseBonnard LouiseBonnard added Good first issue Community: beginner-friendly issues PM ✔️ Status: check done, behavior approved labels Nov 20, 2020
@LouiseBonnard LouiseBonnard removed their assignment Nov 20, 2020
@hibatallahAouadni hibatallahAouadni mentioned this issue Jan 4, 2021
Open
20 tasks
@matks matks changed the title 2 timezones pacific in installer Two timezones pacific in installer Mar 29, 2021
@hibatallahAouadni hibatallahAouadni added Verified The issue has been reproduced and removed 1.7.6.0 Affects versions labels Jun 20, 2022
This was referenced Sep 16, 2022
Merged
Merged
@prestonBot prestonBot added the PR available Solution: issue is being addressed label Sep 16, 2022
@Progi1984 Progi1984 self-assigned this Sep 16, 2022
@PrestaEdit PrestaEdit mentioned this issue Oct 9, 2022
Closed
@prestashop-issue-bot prestashop-issue-bot bot removed the Ready Status: Issue is ready to be worked on label Oct 27, 2022
@HanaRebaiQA HanaRebaiQA added the Fixed Resolution: issue closed because fixed label Oct 28, 2022
@HanaRebaiQA
Copy link

Fixed by PrestaShop/autoupgrade#507 & #29664

@HanaRebaiQA HanaRebaiQA removed the Fixed Resolution: issue closed because fixed label Oct 28, 2022
@HanaRebaiQA HanaRebaiQA added the Fixed Resolution: issue closed because fixed label Oct 28, 2022
@Progi1984 Progi1984 added this to the 8.1.0 milestone Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Progi1984 Progi1984

Labels
1.7.5.2 Affects versions Bug Type: Bug Fixed Resolution: issue closed because fixed Good first issue Community: beginner-friendly issues IN Category: Install PM ✔️ Status: check done, behavior approved PR available Solution: issue is being addressed Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification Verified The issue has been reproduced
Projects
None yet
Milestone
8.1.0
8 participants
@PierreRambaud @Progi1984 @marionf @prestonBot @hibatallahAouadni @LouiseBonnard @colinegin @HanaRebaiQA