Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BO - Add new Order page - Gift message cannot be removed #24562

Closed
khouloudbelguith opened this issue May 19, 2021 · 1 comment · Fixed by #24576
Closed

BO - Add new Order page - Gift message cannot be removed #24562

khouloudbelguith opened this issue May 19, 2021 · 1 comment · Fixed by #24576
Assignees
@Progi1984
Labels
1.7.7.4 Affects versions 1.7.8.x Branch BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Order settings Label: Which BO under menu is concerned Order Component: Which BO section is concerned PR available Solution: issue is being addressed Regression Type: regression
Milestone
1.7.7.5

Comments

@khouloudbelguith
Copy link
Contributor

Describe the bug

In the BO > Orders > Add new Order page > When we set a gift message, then we try to delete it, it is not possible to remove it.
It is always displayed

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to BO > Shop Parameters > Order Settings page
  2. Enable Offer gift wrapping
  3. Go to BO > Orders > Add new Order page
  4. Choose a customer & choose a product
  5. In the Shipping block, Enable gift & set a gift message
  6. Try to remove the gift message
  7. Click outside or (disable/enable gift)
  8. See error => message is back

Screenshots

https://drive.google.com/file/d/1CwasVUJjF5oIl0uxAj-kE6scMIernP8f/view?usp=sharing

with PS1769 => ok

Additional information

  • PrestaShop version: 1774, 178x
  • PHP version: 7.2, 7.4
@khouloudbelguith khouloudbelguith added 1.7.7.4 Affects versions 1.7.8.x Branch Bug Type: Bug Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Regression Type: regression BO Category: Back Office Order Component: Which BO section is concerned Order settings Label: Which BO under menu is concerned Ready Status: Issue is ready to be worked on labels May 19, 2021
@Progi1984 Progi1984 self-assigned this May 19, 2021
@prestashop-issue-bot prestashop-issue-bot bot added WIP Status: Work In Progress and removed Ready Status: Issue is ready to be worked on labels May 19, 2021
@Progi1984 Progi1984 added this to the 1.7.7.5 milestone May 20, 2021
@Progi1984 Progi1984 mentioned this issue May 20, 2021
Merged
@Progi1984 Progi1984 linked a pull request May 20, 2021 that will close this issue
BO - New Order - Empty gift message is not a null value #24576
Merged
@hibatallahAouadni hibatallahAouadni added Fixed Resolution: issue closed because fixed PR available Solution: issue is being addressed and removed WIP Status: Work In Progress labels May 26, 2021
@prestashop-issue-bot prestashop-issue-bot bot added Needs Specs Status: issue needs to be specified and removed Fixed Resolution: issue closed because fixed labels May 26, 2021
@hibatallahAouadni hibatallahAouadni added Fixed Resolution: issue closed because fixed and removed Needs Specs Status: issue needs to be specified labels May 26, 2021
@Progi1984
Copy link
Member

Fixed in #24576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Progi1984 Progi1984

Labels
1.7.7.4 Affects versions 1.7.8.x Branch BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Order settings Label: Which BO under menu is concerned Order Component: Which BO section is concerned PR available Solution: issue is being addressed Regression Type: regression
Projects
None yet
Milestone
1.7.7.5
Development

Successfully merging a pull request may close this issue.

BO - New Order - Empty gift message is not a null value Progi1984/PrestaShop
3 participants
@Progi1984 @khouloudbelguith @hibatallahAouadni