Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BO - New Order - Empty gift message is not a null value #24576

Merged
merged 1 commit into from May 26, 2021
Merged

BO - New Order - Empty gift message is not a null value #24576

merged 1 commit into from May 26, 2021

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented May 20, 2021 •
edited by PierreRambaud

Questions Answers
Branch? 1.7.7.x
Description? An empty gift message (``) was considered as null and wasn't saved
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #24562
How to test? Cf. #24562

This change is Reviewable

@Progi1984 Progi1984 requested a review from a team as a code owner May 20, 2021 07:15
@prestonBot prestonBot added 1.7.7.x Branch Bug fix Type: Bug fix labels May 20, 2021
@Progi1984 Progi1984 linked an issue May 20, 2021 that may be closed by this pull request
BO - Add new Order page - Gift message cannot be removed #24562
Closed
@Progi1984 Progi1984 added this to the 1.7.7.5 milestone May 20, 2021
jolelievre
jolelievre approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Progi1984

@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label May 20, 2021
@hibatallahAouadni hibatallahAouadni self-assigned this May 20, 2021
@hibatallahAouadni
Copy link
Contributor

Hello @Progi1984

It works ✔️

https://www.awesomescreenshot.com/video/3830162?key=ec7548dcd2ec4a2010c5ea24f2b21d36

But I have a question 😅

  1. Try to create an order from BO
  2. Choose the customer and the products
  3. Activate gift wrapping option and set a message
  4. Do not complete the order
  5. Back to the list of orders
  6. Try to create another order
  7. If you choose the same customer, the gift wrapping option will be activated with the message
  8. If you choose another customer, the gift wrapping option will be activated (but without the message)

https://drive.google.com/file/d/1zkbsArZ7KKuC7loC0W18uzu9YiF9aJ6E/view
So, is this the normal behavior?

Thanks!

@hibatallahAouadni hibatallahAouadni added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels May 21, 2021
@Progi1984
Copy link
Contributor Author

Progi1984 commented May 25, 2021 •
edited by hibatallahAouadni

@hibatallahAouadni I don't know if it is the good behavior (need the @PrestaShop/product-team). But I don't think it's linked to this bug and this PR.

@Progi1984 Progi1984 added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for author Status: action required, waiting for author feedback labels May 25, 2021
@hibatallahAouadni
Copy link
Contributor

Hello @Progi1984

LGTM, QA ✔️
About the other issue, I reproduce it even without PR (so it's not related to PR) and it seems a cache issue cause @Robin-Fischer-PS couldn't reproduce it.

Thanks!

@hibatallahAouadni hibatallahAouadni added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels May 26, 2021
@Progi1984 Progi1984 merged commit 948ecce into PrestaShop:1.7.7.x May 26, 2021
@Progi1984
Copy link
Contributor Author

Thanks @hibatallahAouadni

@Progi1984 Progi1984 deleted the issue24562 branch May 26, 2021 11:30
@Progi1984 Progi1984 mentioned this pull request May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@jolelievre jolelievre jolelievre approved these changes

Assignees

@hibatallahAouadni hibatallahAouadni

Labels
1.7.7.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.7.5
Development

Successfully merging this pull request may close these issues.

BO - Add new Order page - Gift message cannot be removed
5 participants
@Progi1984 @hibatallahAouadni @PierreRambaud @jolelievre @prestonBot