Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BO - Features - Exception when editing a feature #31572

Closed
2 tasks done
florine2623 opened this issue Feb 28, 2023 · 3 comments
Closed
2 tasks done

BO - Features - Exception when editing a feature #31572

florine2623 opened this issue Feb 28, 2023 · 3 comments
Assignees
@boherm
Labels
8.1.x Branch BO Category: Back Office Bug Type: Bug Detected by TE Issue detected by TE Features Label: Which BO under menu is concerned Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification PR available Solution: issue is being addressed Ready Status: Issue is ready to be worked on Regression Type: regression Verified The issue has been reproduced
Milestone
8.1.1

Comments

@florine2623
Copy link
Contributor

Prerequisites

Describe the bug and add attachments

An exception is displayed when I edit a Feature :
An unexpected error occurred. [PrestaShop\PrestaShop\Core\Domain\Feature\Exception\InvalidFeatureIdException code 0]: Invalid feature id '1' supplied. Feature id must be positive integer.

Screenshot 2023-02-28 at 16 43 13

Screen.Recording.2023-02-28.at.16.42.22.mov

This is a regression found by @nesrineabdmouleh .
On 8.0.x, it works properly.

Expected behavior

The edition should be successful

Steps to reproduce

  1. Go to BO > Catalog > Attributes & Features > Feature tab
  2. Edit a Feature
  3. Save
  4. See error ❌

PrestaShop version(s) where the bug happened

8.1.x, develop

PHP version(s) where the bug happened

8.1

If your bug is related to a module, specify its name and its version

No response
@florine2623 florine2623 added Bug Type: Bug Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification BO Category: Back Office Needs Specs Status: issue needs to be specified Features Label: Which BO under menu is concerned Regression Type: regression New New issue not yet processed by QA 8.1.x Branch Detected by TE Issue detected by TE labels Feb 28, 2023
@djoelleuch
Copy link

Hello @florine2623 ,

Thank you for your report, I reproduce the issue with Develop and not with the version 1.7.8.8 as you can see :

with develop :

devFLORINE.webm

with 1.7.8.8

1788florine.mp4

Nice catch ! It's a regression !
thank you

@djoelleuch djoelleuch added Verified The issue has been reproduced and removed New New issue not yet processed by QA labels Mar 1, 2023
@MatShir MatShir added Ready Status: Issue is ready to be worked on and removed Needs Specs Status: issue needs to be specified labels Mar 3, 2023
@boherm boherm mentioned this issue Mar 8, 2023
Merged
@prestonBot prestonBot added the PR available Solution: issue is being addressed label Mar 8, 2023
nicosomb added a commit that referenced this issue Mar 9, 2023
@nicosomb
Merge pull request #31682 from boherm/#31572-fix-exception-on-feature…
c1e3167 
…-editing

Cast `featureId` into int to fix `InvalidFeatureIdException`
@lartist lartist self-assigned this Mar 9, 2023
@lartist
Copy link
Contributor

lartist commented Mar 10, 2023

Hi @florine2623 and @djoelleuch, I didn't succeed to reproduce the bug in 8.1.x. Maybe it has been solved in another PR. Can you confirm the PrestaShop version where the bug occurs in please?

@lartist lartist assigned boherm and unassigned lartist Mar 10, 2023
@lartist
Copy link
Contributor

lartist commented Mar 10, 2023

@boherm already fixed it here #31682
I think we can close this issue

@MatShir MatShir closed this as completed Mar 20, 2023
Progi1984 added a commit to Progi1984/PrestaShop that referenced this issue Jul 24, 2023
@Progi1984
Functional Tests : Unskip test after PrestaShop#31572 is fixed
93a0bab
@Progi1984 Progi1984 mentioned this issue Jul 24, 2023
Merged
boubkerbribri added a commit that referenced this issue Jul 24, 2023
@boubkerbribri
Merge pull request #33352 from Progi1984/unskip31572
af03071 
Functional Tests : Unskip test after #31572 is fixed
@Progi1984 Progi1984 added this to the 8.1.1 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boherm boherm

Labels
8.1.x Branch BO Category: Back Office Bug Type: Bug Detected by TE Issue detected by TE Features Label: Which BO under menu is concerned Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification PR available Solution: issue is being addressed Ready Status: Issue is ready to be worked on Regression Type: regression Verified The issue has been reproduced
Projects
None yet
Milestone
8.1.1
Development

No branches or pull requests
7 participants
@Progi1984 @lartist @florine2623 @boherm @prestonBot @MatShir @djoelleuch