Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional Tests : Unskip test after #31572 is fixed #33352

Merged
merged 2 commits into from Jul 24, 2023
Merged

Functional Tests : Unskip test after #31572 is fixed #33352

merged 2 commits into from Jul 24, 2023

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented Jul 24, 2023 •
edited

Questions Answers
Branch? 8.1.x
Description? Functional Tests : Unskip test after #31572 is fixed
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? CI is 馃煝 & Nightly is 馃煝 : https://github.com/Progi1984/ga.tests.ui.pr/actions/runs/5643877493
Fixed ticket? Fixes #31572
Related PRs N/A
Sponsor company @PrestaShopCorp

@Progi1984 Progi1984 added TE Category: Tests E2E Tests labels Jul 24, 2023
@Progi1984 Progi1984 added this to the 8.1.2 milestone Jul 24, 2023
@prestonBot prestonBot added 8.1.x Branch Improvement Type: Improvement labels Jul 24, 2023
@Progi1984 Progi1984 marked this pull request as ready for review July 24, 2023 12:10
@Progi1984 Progi1984 requested a review from a team as a code owner July 24, 2023 12:10
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Jul 24, 2023
@boubkerbribri boubkerbribri added QA 鉁旓笍 Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 24, 2023
@ps-jarvis ps-jarvis added Waiting for QA Status: action required, waiting for test feedback and removed QA 鉁旓笍 Status: check done, code approved labels Jul 24, 2023
@boubkerbribri
Copy link
Contributor

@Progi1984 is it ok to merge with errors on tests

@Progi1984 Progi1984 added QA 鉁旓笍 Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 24, 2023
@Progi1984
Copy link
Contributor Author

@boubkerbribri Yes

@boubkerbribri boubkerbribri merged commit af03071 into PrestaShop:8.1.x Jul 24, 2023
41 checks passed
@boubkerbribri
Copy link
Contributor

Thanks @Progi1984

@Progi1984 Progi1984 deleted the unskip31572 branch July 24, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@boherm boherm boherm approved these changes

@nesrineabdmouleh nesrineabdmouleh nesrineabdmouleh approved these changes

@boubkerbribri boubkerbribri boubkerbribri approved these changes

Assignees
No one assigned
Labels
8.1.x Branch E2E Tests Improvement Type: Improvement QA 鉁旓笍 Status: check done, code approved TE Category: Tests
Projects
PR Dashboard
Archived in project
Milestone
8.1.2
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Progi1984 @boubkerbribri @matthieu-rolland @boherm @nesrineabdmouleh @ps-jarvis @prestonBot