Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the symfony layout Twig component #33140

Closed
2 tasks done
Tracked by #32875
fabienvallon opened this issue Jul 7, 2023 · 0 comments · Fixed by #33864
Closed
2 tasks done
Tracked by #32875

Create the symfony layout Twig component #33140

fabienvallon opened this issue Jul 7, 2023 · 0 comments · Fixed by #33864
Assignees
Labels
9.0.x Branch CO Category: Core Symfony layout Task Type: neither a bug or a feature
Milestone

Comments

@fabienvallon
Copy link

fabienvallon commented Jul 7, 2023

Description

Once all the components are available we can create the symfony layout in twig that includes all the new components, it is based on admin-dev/themes/new-theme/template/layout.tpl but probably a lot of variables can be renamed or fixed and some blocks can be removed

It should follow the same principle as the twig components, meaning it's based on a Twig component. We need two layouts:

  • a "normal" one that includes the menu and all the side elements
  • a "light" one that is used with all the components around and is used to display content in modals for example (it is based on the liteDisplaying query parameter so far, but this should be improved as well Maybe this could be made automatic via a listener that automatically switches the layout when a query parameter or an attribute is set on the Request (or it could be handled via a LayoutBuilder::layout variable maybe

Blocked by #33101

  • Create the global Twig component with default layout from smarty being extracted into a twig one
  • Make this twig component independent via DI
@fabienvallon fabienvallon mentioned this issue Jul 7, 2023
41 tasks
@fabienvallon fabienvallon changed the title Once all the components are available we can create the symfony layout in twig that includes all the new components, it is based on admin-dev/themes/new-theme/template/layout.tpl but probably a lot of variables can be renamed or fixed and some blocks can be removed [Create the Symfony/twig default layout] Create the symfony layout in twig Jul 7, 2023
@jolelievre jolelievre changed the title [Create the Symfony/twig default layout] Create the symfony layout in twig Create the symfony layout Twig component Jul 10, 2023
@jolelievre jolelievre added 9.0.x Branch Task Type: neither a bug or a feature New New issue not yet processed by QA labels Jul 10, 2023
@hibatallahAouadni hibatallahAouadni added CO Category: Core Needs Specs Status: issue needs to be specified and removed New New issue not yet processed by QA labels Jul 11, 2023
@M0rgan01 M0rgan01 self-assigned this Aug 30, 2023
@prestashop-issue-bot prestashop-issue-bot bot removed Needs Specs Status: issue needs to be specified labels Oct 20, 2023
@matks matks added this to the 9.0.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0.x Branch CO Category: Core Symfony layout Task Type: neither a bug or a feature
Projects
None yet
6 participants