Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twig component: Create global layout #33864

Merged
merged 5 commits into from Oct 20, 2023
Merged

Twig component: Create global layout #33864

merged 5 commits into from Oct 20, 2023

Conversation

M0rgan01
Copy link
Contributor

@M0rgan01 M0rgan01 commented Sep 6, 2023 •
edited

Questions Answers
Branch? develop
Description? Creation of a default layout template and a light layout template, encapsulating the components previously created.
Type? refacto
Category? BO
BC breaks? yes
Deprecations? no
How to test? CI and tests auto are green
UI test? legacy https://github.com/M0rgan01/ga.tests.ui.pr/actions/runs/6559224465 / symfony layout: https://github.com/M0rgan01/ga.tests.ui.pr/actions/runs/6559225593
Fixed issue or discussion? Fixes #33140
Related PRs -
Sponsor company -

BC breaks:

  • remove modal_module_list view in new layout
  • remove modals view in new layout
  • remove custom function getCacheDir in AppKernel (we now use the parent function). We no longer have a directory separator at the end of cacheDir

Note:
Failed tests in the symfony layout are related to the shop context. We will see later if the refacto on the context solves the problem or not

@prestonBot prestonBot added Bug fix Type: Bug fix BC break Type: Introduces a backwards-incompatible break labels Sep 6, 2023
@M0rgan01 M0rgan01 force-pushed the migrate/create_global_component branch 3 times, most recently from bae56ec to dd46e94 Compare September 8, 2023 15:28
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring labels Sep 8, 2023
@boherm boherm force-pushed the migrate/create_global_component branch 3 times, most recently from 5688541 to b51cd92 Compare September 28, 2023 14:36
@M0rgan01 M0rgan01 force-pushed the migrate/create_global_component branch 2 times, most recently from 868956b to 0fa75a2 Compare October 3, 2023 14:53
@boherm
Copy link
Member

boherm commented Oct 4, 2023

Before merging this PR, maybe it could be cool to squash some commits 😇

@M0rgan01 M0rgan01 force-pushed the migrate/create_global_component branch 16 times, most recently from eb4af69 to 576c95e Compare October 5, 2023 07:27
@M0rgan01 M0rgan01 force-pushed the migrate/create_global_component branch 2 times, most recently from eef0472 to a1bbe3a Compare October 17, 2023 16:40
@M0rgan01 M0rgan01 force-pushed the migrate/create_global_component branch 2 times, most recently from 7beae18 to 5fca115 Compare October 18, 2023 12:07
jolelievre
jolelievre previously approved these changes Oct 18, 2023
View reviewed changes
@M0rgan01 M0rgan01 force-pushed the migrate/create_global_component branch from 5fca115 to 4d49949 Compare October 18, 2023 12:44
boherm
boherm approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@boherm boherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Thanks @M0rgan01 ;)

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Oct 18, 2023
@M0rgan01 M0rgan01 mentioned this pull request Oct 19, 2023
Closed
2 tasks
@florine2623 florine2623 self-assigned this Oct 19, 2023
@M0rgan01 M0rgan01 added this to the 9.0.0 milestone Oct 19, 2023
@florine2623
Copy link
Contributor

Tests auto OK, QA OK

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 20, 2023
@M0rgan01 M0rgan01 merged commit 0a53044 into PrestaShop:develop Oct 20, 2023
18 checks passed
@boherm
Copy link
Member

boherm commented Oct 20, 2023

A big step! 👏 Well done guys!

@matks matks added the Key feature Notable feature to be highlighted label Oct 20, 2023
@Hlavtox

This comment was marked as outdated.

Sign in to view
@boherm
Copy link
Member

boherm commented Oct 20, 2023

@Hlavtox Have you try to make a composer install to be sure? I think that you must have the last version of twig to work properly after this PR.

@Hlavtox
Copy link
Contributor

Hlavtox commented Oct 20, 2023 •
edited

@boherm I didn't Boris, running now!

Yes, that solved the issue, false alarm. :D

@jolelievre jolelievre changed the title [Twig component] Create global layout Twig component: Create global layout Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@jolelievre jolelievre jolelievre approved these changes

@boherm boherm boherm approved these changes

Assignees

@florine2623 florine2623

Labels
BC break Type: Introduces a backwards-incompatible break Bug fix Type: Bug fix develop Branch Key feature Notable feature to be highlighted QA ✔️ Status: check done, code approved Refactoring Type: Refactoring
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Create the symfony layout Twig component
9 participants
@M0rgan01 @boherm @florine2623 @Hlavtox @matthieu-rolland @jolelievre @matks @ps-jarvis @prestonBot