Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All assets urls are html encoded with symfony layout FF #34332

Closed
2 tasks done
Hlavtox opened this issue Oct 18, 2023 · 4 comments
Closed
2 tasks done

All assets urls are html encoded with symfony layout FF #34332

Hlavtox opened this issue Oct 18, 2023 · 4 comments
Labels
9.0.x Branch Bug Type: Bug CO Category: Core Symfony layout Waiting for dev Status: action required, waiting for tech feedback

Comments

@Hlavtox
Copy link
Contributor

Hlavtox commented Oct 18, 2023

Prerequisites

Describe the bug and add attachments

Snímek obrazovky 2023-10-18 153952

Expected behavior

It MUST NOT be encoded and it must be the same as before.

Steps to reproduce

  1. Get develop.
  2. Enable "Symfony layout" feature flag.
  3. Go to any symfony page and inspect the source code.

PrestaShop version(s) where the bug happened

develop

PHP version(s) where the bug happened

doesn't matter

If your bug is related to a module, specify its name and its version

No response

Your company or customer's name goes here (if applicable).

No response

Ping @M0rgan01 @jolelievre

@Hlavtox Hlavtox added Bug Type: Bug New New issue not yet processed by QA labels Oct 18, 2023
@florine2623 florine2623 added CO Category: Core NMI Status: issue needs more information Waiting for dev Status: action required, waiting for tech feedback Symfony layout and removed New New issue not yet processed by QA labels Oct 18, 2023
@florine2623
Copy link
Contributor

This can be tested by @PrestaShop/prestashop-core-developers

@hibatallahAouadni hibatallahAouadni added the 9.0.x Branch label Oct 18, 2023
@M0rgan01
Copy link
Contributor

This will be probably resolved by #33864

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Oct 20, 2023

@M0rgan01 Good! PR #33864 solved encoded assets! :-)

However, there are still some encoded URLs:

  • Quick access links
  • Quick access links in search
  • Show my store link
  • Edit links
  • Logo link
  • (just show source code and search for &#)

@M0rgan01
Copy link
Contributor

@Hlavtox Thanks for the list, I will try to correct them between 2 topics

@Hlavtox Hlavtox closed this as completed Mar 26, 2024
@florine2623 florine2623 removed the NMI Status: issue needs more information label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0.x Branch Bug Type: Bug CO Category: Core Symfony layout Waiting for dev Status: action required, waiting for tech feedback
Projects
None yet
Development

No branches or pull requests

4 participants