Fix html encoded urls in symfony layout #34395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
M0rgan01
commented
Oct 26, 2023
•
M0rgan01
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | Fix html encoded urls in symfony layout, see #34332 |
| Type? | bug fix |
| Category? | BO |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | CI and UI tests are green |
| UI Tests | Legacy: https://github.com/M0rgan01/ga.tests.ui.pr/actions/runs/6655446502 / Symfony: https://github.com/M0rgan01/ga.tests.ui.pr/actions/runs/6655448301 |
| Fixed issue or discussion? | Fixes ##34332 |
| Related PRs | - |
| Sponsor company | - |
nicosomb
previously approved these changes
Oct 26, 2023
tleon
previously approved these changes
Oct 26, 2023
ps-jarvis
added
the
Waiting for QA
Hlavtox
requested changes
Oct 26, 2023
There was a problem hiding this comment.
Tested, some things are fixed, some still encoded. ;-)
In these files, the escaping should be also removed:
src/PrestaShopBundle/Resources/views/Admin/Component/Layout/mobile_quick_access.html.twigsrc/PrestaShopBundle/Resources/views/Admin/Component/Layout/quick_access.html.twigsrc/PrestaShopBundle/Resources/views/Admin/Component/Layout/shop_list.html.twig
ps-jarvis
added
the
Waiting for author
Hlavtox
removed
the
Waiting for QA
jolelievre
previously approved these changes
Oct 27, 2023
jolelievre
removed
the
Waiting for author
M0rgan01
dismissed stale reviews from jolelievre, tleon, and nicosomb
via
0bcd09e
|
@Hlavtox @tleon @nicosomb @jolelievre I removed the missing ones |
nicosomb
approved these changes
Oct 27, 2023
tleon
approved these changes
Oct 27, 2023
ps-jarvis
added
the
Waiting for QA
boherm
approved these changes
Oct 27, 2023
Hlavtox
approved these changes
Oct 28, 2023
florine2623
added
QA ✔️
|
thanks @M0rgan01 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.