Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quantity placeholder issue in the Stock management page #10199

Merged
merged 4 commits into from
Nov 16, 2018
Merged

Fix quantity placeholder issue in the Stock management page #10199

merged 4 commits into from
Nov 16, 2018

Conversation

CaptainYouz
Copy link
Contributor

@CaptainYouz CaptainYouz commented Aug 29, 2018 •
edited by eternoendless
Loading

Questions Answers
Branch? develop
Description? This PR fix in BO > Stock Page the UX problem of the quantity placeholder.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #9753
How to test? Change the quantity value manually, with the increase/decrease button and save it to make sure that changes are saved.

This change is Reviewable

@prestonBot prestonBot added develop Branch Improvement Type: Improvement Waiting for wording Status: action required, waiting for wording labels Aug 29, 2018
@CaptainYouz CaptainYouz changed the title BO | Stock: Edit quantity placeholder - #9753 BO | Stock: Edit quantity placeholder Aug 29, 2018
@prestonBot prestonBot added develop Branch Improvement Type: Improvement Waiting for wording Status: action required, waiting for wording labels Aug 29, 2018
@LouiseBonnard LouiseBonnard removed the Waiting for wording Status: action required, waiting for wording label Aug 30, 2018
@PrestaShop PrestaShop deleted a comment from prestonBot Sep 26, 2018
tomlev
tomlev previously approved these changes Nov 12, 2018
View reviewed changes
@marionf marionf added Waiting for QA Status: action required, waiting for test feedback QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 13, 2018
@PierreRambaud
Copy link
Contributor

Merge when tests are ok :)

@Quetzacoalt91 Quetzacoalt91 merged commit 50a4cf7 into PrestaShop:develop Nov 16, 2018
@Quetzacoalt91
Copy link
Member

Thank you @CaptainYouz

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Nov 22, 2018
@eternoendless eternoendless changed the title BO | Stock: Edit quantity placeholder Fix quantity placeholder issue in the Stock management page Apr 8, 2019
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlev tomlev tomlev left review comments

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved Waiting for wording Status: action required, waiting for wording
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.
7 participants
@CaptainYouz @PierreRambaud @Quetzacoalt91 @tomlev @marionf @prestonBot @LouiseBonnard