-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CacheClearer adapter #10770
Merged
matks
merged 12 commits into
PrestaShop:develop
from
sarjon:cache-clearer-implementation
Oct 17, 2018
Merged
Update CacheClearer adapter #10770
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2c53243
implement cache clearers
sarjon af0610a
mark cache clearers as internal
sarjon 25c0f80
use new cache clearer in LanguagePackImporter
sarjon fc76937
update cache clear in Performance controller
sarjon 1c44cca
fix entire cache clearer config
sarjon 3431a2f
use symfony cache clearer in CachingConfiguration
sarjon 05464bd
update CacheClearer adapter
sarjon f27bdbd
add deprecation docs
sarjon abb7629
cs fixer
sarjon 40e8b23
update cache clearer naming
sarjon f433b2f
add deprecation notices
sarjon 2ccdb0e
update tests
sarjon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
<?php | ||
/** | ||
* 2007-2018 PrestaShop. | ||
* | ||
* NOTICE OF LICENSE | ||
* | ||
* This source file is subject to the Open Software License (OSL 3.0) | ||
* that is bundled with this package in the file LICENSE.txt. | ||
* It is also available through the world-wide-web at this URL: | ||
* https://opensource.org/licenses/OSL-3.0 | ||
* If you did not receive a copy of the license and are unable to | ||
* obtain it through the world-wide-web, please send an email | ||
* to license@prestashop.com so we can send you a copy immediately. | ||
* | ||
* DISCLAIMER | ||
* | ||
* Do not edit or add to this file if you wish to upgrade PrestaShop to newer | ||
* versions in the future. If you wish to customize PrestaShop for your | ||
* needs please refer to http://www.prestashop.com for more information. | ||
* | ||
* @author PrestaShop SA <contact@prestashop.com> | ||
* @copyright 2007-2018 PrestaShop SA | ||
* @license https://opensource.org/licenses/OSL-3.0 Open Software License (OSL 3.0) | ||
* International Registered Trademark & Property of PrestaShop SA | ||
*/ | ||
|
||
namespace PrestaShop\PrestaShop\Adapter\Cache\Clearer; | ||
|
||
use PrestaShop\PrestaShop\Core\Cache\Clearer\CacheClearerInterface; | ||
use PrestaShopAutoload; | ||
|
||
/** | ||
* Class ClassIndexCacheClearer clears current class index and generates new one. | ||
* | ||
* @internal | ||
*/ | ||
final class ClassIndexCacheClearer implements CacheClearerInterface | ||
{ | ||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function clear() | ||
{ | ||
PrestaShopAutoload::getInstance()->generateIndex(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
<?php | ||
/** | ||
* 2007-2018 PrestaShop. | ||
* | ||
* NOTICE OF LICENSE | ||
* | ||
* This source file is subject to the Open Software License (OSL 3.0) | ||
* that is bundled with this package in the file LICENSE.txt. | ||
* It is also available through the world-wide-web at this URL: | ||
* https://opensource.org/licenses/OSL-3.0 | ||
* If you did not receive a copy of the license and are unable to | ||
* obtain it through the world-wide-web, please send an email | ||
* to license@prestashop.com so we can send you a copy immediately. | ||
* | ||
* DISCLAIMER | ||
* | ||
* Do not edit or add to this file if you wish to upgrade PrestaShop to newer | ||
* versions in the future. If you wish to customize PrestaShop for your | ||
* needs please refer to http://www.prestashop.com for more information. | ||
* | ||
* @author PrestaShop SA <contact@prestashop.com> | ||
* @copyright 2007-2018 PrestaShop SA | ||
* @license https://opensource.org/licenses/OSL-3.0 Open Software License (OSL 3.0) | ||
* International Registered Trademark & Property of PrestaShop SA | ||
*/ | ||
|
||
namespace PrestaShop\PrestaShop\Adapter\Cache\Clearer; | ||
|
||
use Media; | ||
use PrestaShop\PrestaShop\Core\Cache\Clearer\CacheClearerInterface; | ||
|
||
/** | ||
* Class MediaCacheClearer clears Front Office theme's Javascript & CSS cache. | ||
* | ||
* @internal | ||
*/ | ||
final class MediaCacheClearer implements CacheClearerInterface | ||
{ | ||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function clear() | ||
{ | ||
Media::clearCache(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
<?php | ||
/** | ||
* 2007-2018 PrestaShop. | ||
* | ||
* NOTICE OF LICENSE | ||
* | ||
* This source file is subject to the Open Software License (OSL 3.0) | ||
* that is bundled with this package in the file LICENSE.txt. | ||
* It is also available through the world-wide-web at this URL: | ||
* https://opensource.org/licenses/OSL-3.0 | ||
* If you did not receive a copy of the license and are unable to | ||
* obtain it through the world-wide-web, please send an email | ||
* to license@prestashop.com so we can send you a copy immediately. | ||
* | ||
* DISCLAIMER | ||
* | ||
* Do not edit or add to this file if you wish to upgrade PrestaShop to newer | ||
* versions in the future. If you wish to customize PrestaShop for your | ||
* needs please refer to http://www.prestashop.com for more information. | ||
* | ||
* @author PrestaShop SA <contact@prestashop.com> | ||
* @copyright 2007-2018 PrestaShop SA | ||
* @license https://opensource.org/licenses/OSL-3.0 Open Software License (OSL 3.0) | ||
* International Registered Trademark & Property of PrestaShop SA | ||
*/ | ||
|
||
namespace PrestaShop\PrestaShop\Adapter\Cache\Clearer; | ||
|
||
use PrestaShop\PrestaShop\Core\Cache\Clearer\CacheClearerInterface; | ||
use Tools; | ||
|
||
/** | ||
* Class SmartyCacheClearer clears Smarty cache. | ||
* | ||
* @internal | ||
*/ | ||
final class SmartyCacheClearer implements CacheClearerInterface | ||
{ | ||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function clear() | ||
{ | ||
Tools::clearSmartyCache(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
<?php | ||
/** | ||
* 2007-2018 PrestaShop. | ||
* | ||
* NOTICE OF LICENSE | ||
* | ||
* This source file is subject to the Open Software License (OSL 3.0) | ||
* that is bundled with this package in the file LICENSE.txt. | ||
* It is also available through the world-wide-web at this URL: | ||
* https://opensource.org/licenses/OSL-3.0 | ||
* If you did not receive a copy of the license and are unable to | ||
* obtain it through the world-wide-web, please send an email | ||
* to license@prestashop.com so we can send you a copy immediately. | ||
* | ||
* DISCLAIMER | ||
* | ||
* Do not edit or add to this file if you wish to upgrade PrestaShop to newer | ||
* versions in the future. If you wish to customize PrestaShop for your | ||
* needs please refer to http://www.prestashop.com for more information. | ||
* | ||
* @author PrestaShop SA <contact@prestashop.com> | ||
* @copyright 2007-2018 PrestaShop SA | ||
* @license https://opensource.org/licenses/OSL-3.0 Open Software License (OSL 3.0) | ||
* International Registered Trademark & Property of PrestaShop SA | ||
*/ | ||
|
||
namespace PrestaShop\PrestaShop\Adapter\Cache\Clearer; | ||
|
||
use PrestaShop\PrestaShop\Core\Cache\Clearer\CacheClearerInterface; | ||
use Tools; | ||
|
||
/** | ||
* Class SymfonyCacheClearer clears Symfony cache directly from filesystem. | ||
* | ||
* @internal | ||
*/ | ||
final class SymfonyCacheClearer implements CacheClearerInterface | ||
{ | ||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function clear() | ||
{ | ||
Tools::clearSf2Cache(); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Watch out, with this you introduce a BC break because of the necessary of having parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know, but do
Adapters
promise BC? i think that modules should not depend on adapters, but if they do, then they should not expect BC as adapters are temporary services that can change/be removed at any time, no? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is always a difference between what we think and what users do :D Maybe we can for the moment use a function like
addCacheClearer
and call this classCacheClearerChain
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this, we sure we don't have BC or anything else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i could just leave this
CacheClearer
untouched, because if it is used in some module (even though it shouldnt :D) it will break as you must calladdCacheClearer
to make it work, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about the backward compatibility for
Adapter
services as well, but anyway I think anaddCacheClearer
method here wouldn't hurt anyway if you need to add an extra cache clearer layerIf some module is using the service via the container (
->get('service_name')
) it won't make a difference anyway, if it instanciated it manually, there's nothing we can do anyway.. too bad for themThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matks wdyt? i dont really want do add non interfaced method to a service. we could either dispatch event though which you could add more cache clearers or just use composition.