Prevent unvalidated form without checkboxes

[Quetzacoalt91]

Questions	Answers
Branch?	1.7.5.x
Description?	When you try to generate an invoice pdf from order statuses, we expect an error when you don't check any checkbox.
Type?	bug fix
Category?	BO
BC breaks?	Nope
Deprecations?	Nope
Fixed ticket?	Fixes #10474
How to test?	See ticket for details. When you generate the invoices from order statuses without checking any status, an error message must be displayed.

---

This change is 

[matks]

@Quetzacoalt91 I dont understand. According to FormInterface.php:

    /**
     * Inspects the given request and calls {@link submit()} if the form was
     * submitted.
     *
     * Internally, the request is forwarded to the configured
     * {@link RequestHandlerInterface} instance, which determines whether to
     * submit the form or not.
     *
     * @param mixed $request The request to handle
     *
     * @return $this
     */
    public function handleRequest($request = null);

So why do you need to force the submit ?

[Quetzacoalt91]

It seems that if not checkbox is checked in the "get invoices by status", the form is considered as "not submitted".
This means the validators are not called, and we never get the error message "you must select at least one order status". With this change, I force the form check to be done. There is probably another way to do so, but that's the only one I found.

[matks]

@Quetzacoalt91 Fair enough 😉

[marionf]

@Quetzacoalt91

If I check a state whith invoice I have the error message while I shouldn't:

If I check a state without invoices, I should have the error message "No invoice found for this state"

[Quetzacoalt91]

Nice catch. PR modified to send only form data. :)

[PierreRambaud]

Thanks @Quetzacoalt91