Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent unnecessary Order objects from being created in Admin Orders #11235

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Prevent unnecessary Order objects from being created in Admin Orders #11235

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed96481
Prevent unnecessary Order objects from being created when setting an …
mnastalski Nov 2, 2018
5898022
Improve backwards compatibility when setting an order's currency in A…
mnastalski Nov 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions controllers/admin/AdminOrdersController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,7 @@ public function __construct()

public static function setOrderCurrency($echo, $tr)
{
$order = new Order($tr['id_order']);

return Tools::displayPrice($echo, (int) $order->id_currency);
return Tools::displayPrice($echo, (int) $tr['id_currency']);
}

public function initPageHeaderToolbar()
Expand Down