New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashing for bulk actions #11394

Merged
merged 4 commits into from Nov 15, 2018

Conversation

Projects
None yet
6 participants
@sarjon
Member

sarjon commented Nov 14, 2018

Questions Answers
Branch? 1.7.5.x
Description? See issue.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #10836
How to test? Should fix issue.

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Nov 14, 2018

@ntiepresta ntiepresta self-assigned this Nov 14, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Nov 14, 2018

@ntiepresta ntiepresta removed their assignment Nov 14, 2018

@matks

This comment has been minimized.

Contributor

matks commented Nov 14, 2018

Tests should be updated 😄 but that is a very good thing

@ntiepresta

This comment has been minimized.

ntiepresta commented Nov 15, 2018

OK 👍

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Nov 15, 2018

Unfortunately, the tests don't pass. :(

@Quetzacoalt91 Quetzacoalt91 merged commit e903e3e into PrestaShop:1.7.5.x Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Nov 15, 2018

Thank you @sarjon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment