Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashing for bulk actions #11394

Merged
merged 4 commits into from
Nov 15, 2018
Merged

Fix crashing for bulk actions #11394

merged 4 commits into from
Nov 15, 2018

Conversation

sarjon
Copy link
Contributor

@sarjon sarjon commented Nov 14, 2018 •
edited by eternoendless
Loading

Questions Answers
Branch? 1.7.5.x
Description? See issue.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #10836
How to test? Should fix issue.

This change is Reviewable

@prestonBot prestonBot added 1.7.5.x Branch Bug Type: Bug labels Nov 14, 2018
@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Nov 14, 2018
PierreRambaud
PierreRambaud previously approved these changes Nov 14, 2018
View reviewed changes
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Nov 14, 2018
@ntiepresta ntiepresta self-assigned this Nov 14, 2018
@ntiepresta ntiepresta added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 14, 2018
@ntiepresta ntiepresta removed their assignment Nov 14, 2018
@matks
Copy link
Contributor

matks commented Nov 14, 2018

Tests should be updated 😄 but that is a very good thing

@matks matks added the Waiting for author Status: action required, waiting for author feedback label Nov 14, 2018
@ntiepresta
Copy link
Contributor

ntiepresta commented Nov 15, 2018 •
edited
Loading

OK 👍

@Quetzacoalt91
Copy link
Member

Unfortunately, the tests don't pass. :(

@Quetzacoalt91 Quetzacoalt91 removed the Waiting for author Status: action required, waiting for author feedback label Nov 15, 2018
@Quetzacoalt91 Quetzacoalt91 merged commit e903e3e into PrestaShop:1.7.5.x Nov 15, 2018
@Quetzacoalt91
Copy link
Member

Thank you @sarjon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

@PierreRambaud PierreRambaud PierreRambaud left review comments

Assignees
No one assigned
Labels
1.7.5.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sarjon @matks @ntiepresta @Quetzacoalt91 @PierreRambaud @prestonBot