Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with the link Manage tax rules in the pricing tab #12497

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Fix issue with the link Manage tax rules in the pricing tab #12497

merged 1 commit into from
Jul 24, 2019

Conversation

khouloudbelguith
Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Feb 7, 2019 •
edited by eternoendless
Loading

Questions Answers
Branch? develop
Description? In product page, in the pricing tab, if you click on the link "Manage tax rules", we are redirected to the Taxes page, so all new modification in this product will disappear, it would be nice that link opens on a new window when clicking in it.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #12475
How to test? *Go to BO => Catalog => Product page => Pricing Tab => Click on the link "Manage tax rules" => a new page is opened

This change is Reviewable

@prestonBot prestonBot added develop Branch Bug Type: Bug labels Feb 7, 2019
@khouloudbelguith khouloudbelguith mentioned this pull request Feb 7, 2019
Closed
PierreRambaud
PierreRambaud previously approved these changes Jul 11, 2019
View reviewed changes
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Jul 11, 2019
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 12, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Jul 12, 2019
@khouloudbelguith khouloudbelguith requested a review from a team as a code owner July 24, 2019 08:56
@PierreRambaud PierreRambaud merged commit 9021780 into PrestaShop:develop Jul 24, 2019
@PierreRambaud
Copy link
Contributor

Thanks @khouloudbelguith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

Issue with the link "Manage tax rules in the pricing tab
4 participants
@khouloudbelguith @PierreRambaud @sarahdib @prestonBot