Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with the link Manage tax rules in the pricing tab #12497

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@khouloudbelguith
Copy link
Contributor

commented Feb 7, 2019

Questions Answers
Branch? develop
Description? In product page, in the pricing tab, if you click on the link "Manage tax rules", we are redirected to the Taxes page, so all new modification in this product will disappear, it would be nice that link opens on a new window when clicking in it.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #12475
How to test? *Go to BO => Catalog => Product page => Pricing Tab => Click on the link "Manage tax rules" => a new page is opened

This change is Reviewable

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 12, 2019

@sarahdib sarahdib added this to the 1.7.7.0 milestone Jul 12, 2019

@PierreRambaud PierreRambaud force-pushed the khouloudbelguith:fix-issues-12475 branch from 5dbedee to 22902a1 Jul 24, 2019

@khouloudbelguith khouloudbelguith requested a review from PrestaShop/prestashop-core-developers as a code owner Jul 24, 2019

@PierreRambaud PierreRambaud merged commit 9021780 into PrestaShop:develop Jul 24, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

Thanks @khouloudbelguith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.