Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CO] Bugfix ReplaceProcessor.php to PHP 7.1 and 7.2 #12642

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@Nobodaddy
Copy link
Contributor

Nobodaddy commented Feb 20, 2019

Just another bugfix for PHP 7.1 and 7.2

Questions Answers
Branch? 1.6.1.x
Description? Bugfix for PHP 7.1 and 7.2 to make the SQL Manager work again. Must be applied together with #12643
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? (optional) If this PR fixes an Issue, please write "Fixes #[issue number]" here.
How to test? Please indicate how to best verify that this PR is correct.

This change is Reviewable

Update ReplaceProcessor.php
Just another bugfix for PHP 7.1 and 7.2

@prestonBot prestonBot added the Bug label Feb 20, 2019

@Nobodaddy Nobodaddy changed the title Adapted ReplaceProcessor.php to PHP 7.1 and 7.2 [CO] Adapted ReplaceProcessor.php to PHP 7.1 and 7.2 Feb 20, 2019

@prestonBot prestonBot added the 1.6.1.x label Feb 20, 2019

@Nobodaddy Nobodaddy changed the title [CO] Adapted ReplaceProcessor.php to PHP 7.1 and 7.2 [CO] Bugfix ReplaceProcessor.php to PHP 7.1 and 7.2 Feb 20, 2019

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Feb 21, 2019

Hello @Nobodaddy,

how can we validate this pull request, please?

Thanks

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Feb 21, 2019

First of all, thank you for contributing to the PrestaShop project!

As you may already know, normal maintenance support for PrestaShop 1.6 ended in October 2018, which is now in extended maintenance mode until June 30, 2019.

During this period, and in order to ensure the stability of current 1.6 shops, only critical bugs and and security fixes will be accepted in the 1.6.1.x branch. If your contribution applies also to the 1.7 branch, please rebase it into the develop branch so that we may include it into the next 1.7 release.

Thanks for your understanding!

@Nobodaddy Nobodaddy deleted the Nobodaddy:patch-86 branch Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.