[POC] Support of modern controllers on module tabs

[mickaelandrieu]

Questions	Answers
Branch?	develop
Description?	Allow modern controllers to be registered using Module::$tabs property.
Type?	improvement
Category?	BO
BC breaks?	no
Deprecations?	no
Fixed ticket?	dunno
How to test?	it's a POC, I won't have time to finish it (and unregistration may be updated accordingly?)

ping @Quetzacoalt91 for review ;)

Use

   $this->tabs = array(
        array(
            'name' => 'Yolo',
            'class_name' => 'adminmessageoftheday', // legacy
            'visible' => true,
            'parent_class_name' => 'AdminTraining',
        ),
        array(
            'name' => 'Yolo2',
            'class_name' => ExempleController::class,
            'legacy_class_name' => 'AdminTrainingIndexClass',
            'visible' => true,
            'parent_class_name' => 'AdminTraining',
        ));

admin_ps_training_index:
  path: /training/
  methods: [GET]
  defaults:
    _controller: 'PrestaShop\Training\Controller\Admin\ExempleController::indexAction'
    _legacy_controller: 'AdminTrainingIndexClass'
    _legacy_link: 'AdminTrainingIndexClass'

---

This change is 

[mickaelandrieu]

maybe this comment/todo can be dropped now?

[Quetzacoalt91]

What's the difference between this and

         if ($className instanceof FrameworkBundleAdminController) { 

[PierreRambaud]

An example si better than a long story: https://www.php.net/manual/en/internals2.opcodes.instanceof.php#109108
But don't know why you use is_subclass_of here 🤔

[Quetzacoalt91]

Yeah I know the difference, my question was actually the same as yours. Is there a specific need here?

[mickaelandrieu]

if I remember well, instanceof only accepts instances and not class names: if I'm wrong, I'm also in favor of using instanceof instead.

instanceof est utilisé pour déterminer si une variable PHP est un objet instancié d'une certaine classe

[mickaelandrieu]

thinking about it, it's a very naive implementation: I should check for the existence of this parameter and throw an exception with a meaningful message pointing to the docs: wdyt?

[mickaelandrieu]

Closed in favor of #12640

[mickaelandrieu]

ping @jolelievre : as this issue is still not fixed, would you consider this contribution ?

Just noticed you have worked on #14679 👍

[jolelievre]

Yes, I was about to tell you but you found it :)