Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force disabling debug mode #14151

Merged
merged 3 commits into from
Jun 12, 2019
Merged

Force disabling debug mode #14151

merged 3 commits into from
Jun 12, 2019

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Jun 11, 2019

Questions Answers
Branch? 1.7.6.x
Description? Force disabling debug mode.
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? Travis must be green.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from a team as a code owner June 11, 2019 08:37
@prestonBot prestonBot added 1.7.6.x Branch Improvement Type: Improvement Waiting for wording Status: action required, waiting for wording labels Jun 11, 2019
@PierreRambaud PierreRambaud changed the base branch from develop to 1.7.6.x June 11, 2019 08:38
matks
matks previously approved these changes Jun 11, 2019
@matks matks removed the Waiting for wording Status: action required, waiting for wording label Jun 11, 2019
@Quetzacoalt91
Copy link
Member

I see we have an override of the docker_run.sh file from the docker image

Just to let you know, the dev mode can be enabled in the original image via env vars: https://github.com/PrestaShop/docker/blob/master/base/config_files/defines_custom.inc.php

Quetzacoalt91
Quetzacoalt91 previously approved these changes Jun 11, 2019
@PierreRambaud PierreRambaud changed the title Force disabling debug mode [WIP] Force disabling debug mode Jun 11, 2019
@PierreRambaud PierreRambaud dismissed stale reviews from Quetzacoalt91 and matks via 9b1ea3e June 11, 2019 14:21
@PierreRambaud PierreRambaud changed the title [WIP] Force disabling debug mode Force disabling debug mode Jun 11, 2019
matks
matks previously approved these changes Jun 11, 2019
@matks
Copy link
Contributor

matks commented Jun 11, 2019

Thank you @PierreRambaud

@PierreRambaud
Copy link
Contributor Author

@Quetzacoalt91 Yeah, we replace the docker_run.sh because we want to reset PrestaShop installation each time the container is up. Didn't notice the custom var, Thanks. I will try with it

@Quetzacoalt91 Quetzacoalt91 merged commit 7d8e28f into PrestaShop:1.7.6.x Jun 12, 2019
@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Jun 12, 2019
@PierreRambaud PierreRambaud deleted the e2e-debug-mode branch June 12, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.6.x Branch Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants