Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case-insensitive hook dispatching #14249

Merged
merged 5 commits into from
Jul 11, 2019
Merged

Case-insensitive hook dispatching #14249

merged 5 commits into from
Jul 11, 2019

Conversation

tomas862
Copy link
Contributor

@tomas862 tomas862 commented Jun 17, 2019 •
edited by eternoendless
Loading

Questions Answers
Branch? develop
Description? dispatching the hook abcFooBar or ABCFooBar or abcFOOBAR makes the module hook being triggered in all cases.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #10412
How to test? Automated tests should cover all possible cases for this

This change is Reviewable

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Jun 17, 2019
@tomas862 tomas862 changed the title [WIP] adds lower case support when dispatching a hook in any form [WIP] case-insensitive hook dispatching Jun 17, 2019
@tomas862 tomas862 marked this pull request as ready for review June 17, 2019 14:12
@tomas862 tomas862 requested a review from a team as a code owner June 17, 2019 14:12
@tomas862 tomas862 changed the title [WIP] case-insensitive hook dispatching case-insensitive hook dispatching Jun 17, 2019
@tomas862
Copy link
Contributor Author

@matks ready for review

@matks matks added the migration symfony migration project label Jun 24, 2019
@matks matks changed the title case-insensitive hook dispatching Case-insensitive hook dispatching Jul 9, 2019
mickaelandrieu
mickaelandrieu reviewed Jul 11, 2019
View reviewed changes
Copy link
Contributor

@mickaelandrieu mickaelandrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to discuss this fix

mickaelandrieu
mickaelandrieu approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@mickaelandrieu mickaelandrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a real check, it fits the strategy we have decided in #10412

👍 good for me

@mickaelandrieu
Copy link
Contributor

As you can see, hooks names are preserved in the Web Profiler.

hooks_preserved

@matks
Copy link
Contributor

matks commented Jul 11, 2019

Thank you @tomas862

@matks matks added this to the 1.7.7.0 milestone Jul 11, 2019
@matks matks merged commit 6054277 into PrestaShop:develop Jul 11, 2019
@matks matks mentioned this pull request Jul 11, 2019
Closed
mbadrani pushed a commit to mbadrani/PrestaShop that referenced this pull request Jul 18, 2019
@matks @mbadrani
Merge pull request PrestaShop#14249 from tomas862/bugfix/hook-dispatcher
dc8af4a 
Case-insensitive hook dispatching
@matks matks mentioned this pull request Aug 20, 2019
Closed
@matks matks mentioned this pull request May 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickaelandrieu mickaelandrieu mickaelandrieu approved these changes

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement migration symfony migration project
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tomas862 @mickaelandrieu @matks @PierreRambaud @prestonBot