Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case-insensitive hook dispatching #14249

Merged
merged 5 commits into from Jul 11, 2019

Conversation

@tomas862
Copy link
Member

commented Jun 17, 2019

Questions Answers
Branch? develop
Description? dispatching the hook abcFooBar or ABCFooBar or abcFOOBAR makes the module hook being triggered in all cases.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #10412
How to test? Automated tests should cover all possible cases for this

This change is Reviewable

@tomas862 tomas862 changed the title [WIP] adds lower case support when dispatching a hook in any form [WIP] case-insensitive hook dispatching Jun 17, 2019

@tomas862 tomas862 marked this pull request as ready for review Jun 17, 2019

@tomas862 tomas862 requested a review from PrestaShop/prestashop-core-developers as a code owner Jun 17, 2019

@tomas862 tomas862 changed the title [WIP] case-insensitive hook dispatching case-insensitive hook dispatching Jun 17, 2019

@tomas862

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2019

@matks ready for review

@matks matks added the migration label Jun 24, 2019

tomas862 added some commits Jun 25, 2019

@matks matks changed the title case-insensitive hook dispatching Case-insensitive hook dispatching Jul 9, 2019

@mickaelandrieu
Copy link
Contributor

left a comment

we need to discuss this fix

@mickaelandrieu
Copy link
Contributor

left a comment

After a real check, it fits the strategy we have decided in #10412

👍 good for me

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

As you can see, hooks names are preserved in the Web Profiler.

hooks_preserved

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Thank you @tomas862

@matks matks added this to the 1.7.7.0 milestone Jul 11, 2019

@matks matks merged commit 6054277 into PrestaShop:develop Jul 11, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matks matks referenced this pull request Jul 11, 2019

mbadrani added a commit to mbadrani/PrestaShop that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.