Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing fields validation in tax create/edit handlers #14310

Merged
merged 1 commit into from Jul 3, 2019
Merged

Adds missing fields validation in tax create/edit handlers #14310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Adapter/Tax/CommandHandler/AddTaxHandler.php
View file
Open in desktop
Expand Up @@ -53,6 +53,10 @@ public function handle(AddTaxCommand $command)
$tax->active = $command->isEnabled();

try {
if (false === $tax->validateFields(false) || false === $tax->validateFieldsLang(false)) {
throw new TaxException('Tax contains invalid field values');
}

if (!$tax->save()) {
throw new TaxException(
sprintf('Cannot create tax with id "%s"', $tax->id)
Expand Down
4 changes: 4 additions & 0 deletions src/Adapter/Tax/CommandHandler/EditTaxHandler.php
View file
Open in desktop
Expand Up @@ -58,6 +58,10 @@ public function handle(EditTaxCommand $command)
}

try {
if (false === $tax->validateFields(false) || false === $tax->validateFieldsLang(false)) {
throw new TaxException('Tax contains invalid field values');
}

if (!$tax->update()) {
throw new TaxException(
sprintf('Cannot update tax with id "%s"', $tax->id)
Expand Down