Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor theme usage of product flags - apply DRY #14422

Merged

Conversation

@matks
Copy link
Contributor

commented Jun 28, 2019

Questions Answers
Branch? develop
Description? I added a @todo in PR #14325 because it was not the right moment to perform some impacting refactoring. Now is the good time, so I de-duplicated some HTML in Classic Theme. See #14325 (comment)
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Please check that #14321 issue is still solved and Product page and FO pages that have a list of product display correctly the small label on the image (see #14321)

This change is Reviewable

@matks matks requested a review from PrestaShop/prestashop-core-developers as a code owner Jun 28, 2019

@jolelievre
Copy link
Contributor

left a comment

just follow the instructions 😅

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 4, 2019

@sarahdib sarahdib added this to the 1.7.7.0 milestone Jul 4, 2019

@matks

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

Thanks for review

@matks matks merged commit a27394b into PrestaShop:develop Jul 4, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@matks matks deleted the matks:handle-duplicated-flags-block-in-theme branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.