Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor theme usage of product flags - apply DRY #14422

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Refactor theme usage of product flags - apply DRY #14422

merged 1 commit into from
Jul 4, 2019

Conversation

matks
Copy link
Contributor

@matks matks commented Jun 28, 2019 •
edited by eternoendless
Loading

Questions Answers
Branch? develop
Description? I added a @todo in PR #14325 because it was not the right moment to perform some impacting refactoring. Now is the good time, so I de-duplicated some HTML in Classic Theme. See #14325 (comment)
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Please check that #14321 issue is still solved and Product page and FO pages that have a list of product display correctly the small label on the image (see #14321)

This change is Reviewable

@matks matks requested a review from a team as a code owner June 28, 2019 13:52
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Jul 1, 2019
jolelievre
jolelievre approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just follow the instructions 😅

@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jul 4, 2019
@sarahdib sarahdib added this to the 1.7.7.0 milestone Jul 4, 2019
@matks
Copy link
Contributor Author

matks commented Jul 4, 2019

Thanks for review

@matks matks merged commit a27394b into PrestaShop:develop Jul 4, 2019
@matks matks deleted the handle-duplicated-flags-block-in-theme branch July 4, 2019 14:24
@ghost ghost added the Front-end Category: Front end label Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@jolelievre jolelievre jolelievre approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch Front-end Category: Front end QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@matks @PierreRambaud @jolelievre @sarahdib @prestonBot