-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get all categories in category tree form (not only enabled ones) #15030
Get all categories in category tree form (not only enabled ones) #15030
Conversation
I could make this simple modification because this CategoryTreeChoiceProvider is only used by one service, which is on only used in the category form. In the future if we need to have another category tree that doesn't take disabled categories into account, then we'll have to make that optional via the constructor, and configure it in It just felt like premature optimization at this point, don't hesitate to tell me if you think otherwise. |
I bet this will become a problem once we try and use the same provider elsewhere. I think we should add the option in the constructor. Remember that other people may be using this class for purposes unknown to us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the option in the constructor
done ! |
Requested change has been applied
@matthieu-rolland PR logic is ✅but codestyle is broken according to PrettyCI |
Thank you @matthieu-rolland |
This change is