Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pop up information on Category deletion #15886

Merged
merged 2 commits into from Oct 15, 2019

Conversation

@Progi1984
Copy link
Contributor

Progi1984 commented Oct 9, 2019

Questions Answers
Branch? develop
Description? Improve pop up information on Category deletion
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15567
How to test? Go in BO > Sell > Catalog > Categories
Select a category
Try to remove it
Wording must be changed.

This change is Reviewable

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers Oct 9, 2019
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Oct 9, 2019
@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

LouiseBonnard commented Oct 9, 2019

Hi @Progi1984, could you please keep the recommended option at the second place like it was in the issue? It looks much more logic when it is read secondly since it refers to the first option.

Also, the note at the end was meant to be displayed. Can you add it? You can keep the same domain. ;-)

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

Progi1984 commented Oct 9, 2019

@LouiseBonnard A note like that ?
image

Poke @TristanLDD @colinegin

@TristanLDD

This comment has been minimized.

Copy link

TristanLDD commented Oct 9, 2019

Hi @Progi1984, I have a few design comments about that popup:

  • Use Google material icons for radio buttons
  • Use the color #7A8A8F instead of red for the radio buttons checked and unchecked states
  • Add 10px of vertical spacing between each options, and 10px of horizontal spacing between radio buttons and option's first letter.
  • Change the wording of the button for "Supprimer la catégorie" so the action is clear (otherwise it's can be unclear if we're talking about deleting products or category)

Thx ! :)

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

Progi1984 commented Oct 9, 2019

Hi @TristanLDD, it's totally out of the scope of the initial issue. In addition to that, I think that a CSS modification like you want impact all modals and not just this one. Could you create an issue for that ?

Initially, I pinged you and @colinegin for the style of the note.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 10, 2019

@Progi1984 I confirm that if it's something more than just wording, we should create a new issue and be sure it's for all modal or only this one :)

@TristanLDD

This comment has been minimized.

Copy link

TristanLDD commented Oct 10, 2019

@Progi1984
I thought we were talking about the popup here, my bad. About the note itself, I'm ok with it.

@Progi1984

This comment has been minimized.

Copy link
Contributor Author

Progi1984 commented Oct 10, 2019

Just waiting for @LouiseBonnard before review

@Progi1984 Progi1984 requested review from PierreRambaud and PrestaShop/prestashop-core-developers Oct 10, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Oct 15, 2019
@jolelievre jolelievre merged commit 2360d5d into PrestaShop:develop Oct 15, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@Progi1984 Progi1984 deleted the Progi1984:issue15567 branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.