Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy Croatian tax rates in EU localization packs #16349

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Copy Croatian tax rates in EU localization packs #16349

merged 1 commit into from
Apr 14, 2020

Conversation

ziegenberg
Copy link
Contributor

@ziegenberg ziegenberg commented Nov 11, 2019 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Copy Croatian tax rates in all EU localization packs
Type? improvement
Category? LO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16336
How to test?

This change is Reviewable

@ziegenberg ziegenberg requested a review from a team as a code owner November 11, 2019 02:36
@prestonBot
Copy link
Collaborator

Hello @ziegenberg!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Nov 11, 2019
@LouiseBonnard LouiseBonnard mentioned this pull request Nov 13, 2019
Closed
19 tasks
Progi1984
Progi1984 reviewed Nov 13, 2019
View reviewed changes
localization/mt.xml Outdated Show resolved Hide resolved
@Progi1984
Copy link
Contributor

@ziegenberg Thank you for your contribution. A small fix with spaces on mt.xml. Could you give a scenario test for checking behavior before and after this PR ? Thanks

@LouiseBonnard LouiseBonnard added Waiting for author Status: action required, waiting for author feedback Waiting for dev Status: action required, waiting for tech feedback labels Nov 13, 2019
@ziegenberg ziegenberg force-pushed the 16336-copy-croatian-tax-rates-in-EU-localization-packs branch from 71ec60d to 9ab646c Compare November 14, 2019 00:08
Progi1984
Progi1984 previously approved these changes Nov 14, 2019
View reviewed changes
@Progi1984
Copy link
Contributor

@ziegenberg Thanks for the fix. Finally, Could you give a scenario test for checking behavior before and after this PR ? After that, I will send your PR to the QA Team. Thanks

@ziegenberg
Copy link
Contributor Author

I'll come up with some testing scenario, but it will take me some days. I'm out of office for the next week.

@eternoendless eternoendless changed the title LO: Copy Croatian tax rates in EU localization packs Copy Croatian tax rates in EU localization packs Nov 18, 2019
@eternoendless eternoendless added this to the 1.7.7.0 milestone Nov 18, 2019
@Progi1984
Copy link
Contributor

@ziegenberg Hello, have you got some news about the test scenario ?

@LouiseBonnard LouiseBonnard added the Waiting for QA Status: action required, waiting for test feedback label Feb 6, 2020
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Feb 6, 2020
@Robin-Fischer-PS
Copy link
Contributor

Hi @ziegenberg ! Could you resolve the conflict on ro.xml file ? Thanks !

@atomiix atomiix force-pushed the 16336-copy-croatian-tax-rates-in-EU-localization-packs branch from 9ab646c to ed4f782 Compare February 7, 2020 09:36
@PierreRambaud PierreRambaud removed the Waiting for QA Status: action required, waiting for test feedback label Feb 10, 2020
@PierreRambaud PierreRambaud added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for author Status: action required, waiting for author feedback Waiting for dev Status: action required, waiting for tech feedback labels Feb 10, 2020
@LouiseBonnard LouiseBonnard removed this from the 1.7.7.0 milestone Feb 13, 2020
@LouiseBonnard LouiseBonnard mentioned this pull request Feb 13, 2020
Open
48 tasks
@sarahdib sarahdib self-assigned this Apr 14, 2020
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 14, 2020
@PierreRambaud PierreRambaud merged commit 82f63a6 into PrestaShop:develop Apr 14, 2020
@PierreRambaud
Copy link
Contributor

Thanks @ziegenberg

@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@atomiix atomiix atomiix approved these changes

@matks matks matks approved these changes

@Progi1984 Progi1984 Progi1984 left review comments

Assignees

@sarahdib sarahdib

@Robin-Fischer-PS Robin-Fischer-PS

Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Copy Croatian tax rates in EU localization packs
10 participants
@ziegenberg @prestonBot @Progi1984 @Robin-Fischer-PS @PierreRambaud @atomiix @matks @eternoendless @sarahdib @LouiseBonnard