PassVsprintfValidator: Add separate regex for arguments only

[jnvsor]

Questions	Answers
Branch?	develop
Description?	Fixes a bug preventing the saving of translations containing a %% literal
Type?	bug fix
Category?	BO
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #16421
How to test?	Attempt a translation containing a literal %% - it will not be saved (Despite a green popup)

---

This change is 

[prestonBot]

Hello @jnvsor!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

[Progi1984]

@jnvsor Thank you for your contribution. Could you open an issue for describing the bug ? Thanks

[jnvsor]

@Progi1984 Added a bug report

[PierreRambaud]

Hi and sorry for the delay,
why not updating the ̀regexSprintfParams` property?

[jnvsor]

Because you still want isSprintfString to return true if the only argument is a %%, otherwise you might break existing strings

[PierreRambaud]

@jnvsor This could be done with a single regex 🤔

[jnvsor]

This could be done with a single regex

By using capture groups? I presume there was a performance reason not to, given that someone went to the effort of making the groups in this regex non-capturing in the first place.

The options as I see them are:

1. Have one regex that matches %% and ignore bug Cannot add literal % to translation strings #16421
2. Have one regex that doesn't match %% and break existing translation strings with %% in them (Though given the existence of Cannot add literal % to translation strings #16421 there may not be many of these)
3. Have two regexes
4. Use capture groups to distinguish between matches and argument counts (Would need more testing if we went that way)

[PierreRambaud]

@jnvsor We should be able to use each characters we want 🤔
Having two regexes = two to maintain.
let's continue the discussion in the issue :)

[matks]

@PierreRambaud Any update :) ?

[PierreRambaud]

@PierreRambaud Any update :) ?

Waiting for a feedback, this solution is not clean IMHO

[matks]

Hello, it seems this PR has no activity since 2020.

I close this PR, following our review guidelines "Pull Requests may be closed after 30 days of inactivity".

If however you are still interested in it, please ping us 😉 we can reopen.

Thank you for your contribution.