Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display 3 products on the same line on home with 2 columns layout #16504

Merged
merged 3 commits into from
Nov 26, 2019
Merged

Display 3 products on the same line on home with 2 columns layout #16504

merged 3 commits into from
Nov 26, 2019

Conversation

NeOMakinG
Copy link

@NeOMakinG NeOMakinG commented Nov 22, 2019 •
edited
Loading

Questions Answers
Branch? develop
Description? If you selected the 2 columns layout on home, you would see 2 product on every single lines
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #16352
How to test? Set layout of your homepage to two columns small left and see if there are 3 products on the same line

This change is Reviewable

@NeOMakinG NeOMakinG requested a review from a team as a code owner November 22, 2019 10:30
@prestonBot prestonBot added develop Branch Bug Type: Bug labels Nov 22, 2019
PierreRambaud
PierreRambaud previously approved these changes Nov 22, 2019
View reviewed changes
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Nov 22, 2019
@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Nov 22, 2019
@eternoendless
Copy link
Member

@NeOMakinG You forgot to fill out the "description" part of the PR table 😉

@sarahdib
Copy link
Contributor

@NeOMakinG
Can you rebase your PR :) ?

Thank you

@sarahdib sarahdib added Waiting for rebase Status: action required, waiting for rebase and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 25, 2019
@PierreRambaud PierreRambaud added Waiting for QA Status: action required, waiting for test feedback and removed Waiting for rebase Status: action required, waiting for rebase labels Nov 25, 2019
PierreRambaud
PierreRambaud previously approved these changes Nov 25, 2019
View reviewed changes
@khouloudbelguith
Copy link
Contributor

Hi @NeOMakinG,

After applying your fix, the way of displaying the product (position) inside a category is changed when we have one or two products.

  1. One product (Men category)
    1.1 Before applying PR:
    image
    1.2. After applying PR:
    image
  2. Two products (Clothes category)
    2.1 Before applying PR:
    image
    2.2. After applying PR:
    image

PS: the index page is OK
image

Thanks!

@khouloudbelguith khouloudbelguith added Waiting for author Status: action required, waiting for author feedback Waiting for dev Status: action required, waiting for tech feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 25, 2019
@NeOMakinG NeOMakinG removed Waiting for author Status: action required, waiting for author feedback Waiting for dev Status: action required, waiting for tech feedback labels Nov 25, 2019
@PierreRambaud PierreRambaud added the Waiting for QA Status: action required, waiting for test feedback label Nov 26, 2019
@khouloudbelguith
Copy link
Contributor

Hi @NeOMakinG,

It is OK.
https://drive.google.com/file/d/1vQhD6G-6LLXnlDZqvn07HAU4tqcx9e1p/view

Thanks!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 26, 2019
@PierreRambaud PierreRambaud merged commit a2d1583 into PrestaShop:develop Nov 26, 2019
@PierreRambaud
Copy link
Contributor

Thanks @NeOMakinG

@eternoendless eternoendless changed the title Displaying 3 products on the same line on home with 2 columns layout Display 3 products on the same line on home with 2 columns layout Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.

Two columns small left column with Recommended Product are not displaying corectly.
6 participants
@NeOMakinG @eternoendless @sarahdib @khouloudbelguith @PierreRambaud @prestonBot