Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new badges to README #17284

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Add new badges to README #17284

merged 1 commit into from
Jan 22, 2020

Conversation

matks
Copy link
Contributor

@matks matks commented Jan 21, 2020 •
edited by eternoendless
Loading

Questions Answers
Branch? develop
Description? Add new badges to README, because developer love badges
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? No QA needed

This change is Reviewable

@matks matks requested a review from a team as a code owner January 21, 2020 16:39
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Jan 21, 2020
@matks
Copy link
Contributor Author

matks commented Jan 21, 2020

You can see the result here
https://github.com/PrestaShop/PrestaShop/blob/e15d084ea8bc529f152bcf89d732b7b0fc8e5ea8/README.md

I thought adding the license would be nice but Github API fails to identify our license 😅

@matks
Copy link
Contributor Author

matks commented Jan 22, 2020

Thanks for review

@matks matks added this to the 1.7.8.0 milestone Jan 22, 2020
@matks matks merged commit d843a0f into PrestaShop:develop Jan 22, 2020
@matks matks deleted the add-badges branch January 22, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@matks @PierreRambaud @Progi1984 @prestonBot