Log Mail subject message correctly in case of alteration

[davideapvd]

Questions	Answers
Branch?	develop
Description?	In Mail.php, in case we alter the message subject with actionMailAlterMessageBeforeSend, the message is logged wrongly, this fixes the log
Type?	bug fix
Category?	CO
BC breaks?	probably if relying on backend logs wrong
Deprecations?	no
Fixed ticket?
How to test?	Implement actionMailAlterMessageBeforeSend and alter the subject like in the following code, check in backend email logs to see the subject is logged correctly

public function hookActionMailAlterMessageBeforeSend($params)
    {
        /**
         * @var Swift_Message $message
         */
        $message = &$params['message'];
        $message->setSubject('altered subject test');
    }

---

This change is 

[SD1982]

Hi @davideapvd Could you provide us more info on "how to test" as a merchant or user would do without having access to the code? And could you also fix the PrettyCi error please?

[PierreRambaud]

Hi @davideapvd Could you provide us more info on "how to test" as a merchant or user would do without having access to the code? And could you also fix the PrettyCi error please?

You can't test without using a module

[davideapvd]

Hi @davideapvd Could you provide us more info on "how to test" as a merchant or user would do without having access to the code? And could you also fix the PrettyCi error please?

hello @SD1982 I think prettyci is reporting something I didn't modify, am I correct?

[PierreRambaud]

Hi @davideapvd Could you provide us more info on "how to test" as a merchant or user would do without having access to the code? And could you also fix the PrettyCi error please?

hello @SD1982 I think prettyci is reporting something I didn't modify, am I correct?

When this happens, you need to rebase your branch based on latest change on the develop branch.

[Robin-Fischer-PS]

Hi @davideapvd @PierreRambaud ! If a module is required to test the PR, could you provide us one, with a scenario ? Thanks ;)

[davideapvd]

@Robin-Fischer-PS sure, here it is the simplest one https://github.com/davideapvd/pr17439 , the method to test the pr is as described in the original message, let me know if that is enough.

[Robin-Fischer-PS]

Thanks a lot @davideapvd ! It's OK for QA :)

[Progi1984]

Thanks @davideapvd