Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduces checkbox in list filter row #17456

Merged
merged 3 commits into from
Feb 6, 2020
Merged

Introduces checkbox in list filter row #17456

merged 3 commits into from
Feb 6, 2020

Conversation

tomas862
Copy link
Contributor

@tomas862 tomas862 commented Jan 31, 2020 •
edited by matks
Loading

Questions Answers
Branch? 1.7.7.x
Description? To fit more into the screen for every migrated list the "Select all" checkbox has been moved to filters row.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #15971 point 4 and I think its the last one from the whole issue
How to test? Please rebuild assets. Go to any or several migrated pages where lists are visible. You should see check all checkbox in different location. Try to use it. See below of some already checked cases


case 1 - filters and bulk actions are both in the list

Screenshot (77)

case 2 - filters are missing from the list

Screenshot (76)

This change is Reviewable

@tomas862 tomas862 requested a review from a team as a code owner January 31, 2020 09:16
@prestonBot prestonBot added 1.7.7.x Branch Improvement Type: Improvement labels Jan 31, 2020
@Progi1984 Progi1984 requested a review from a team January 31, 2020 10:38
@Progi1984 Progi1984 added this to the 1.7.7.0 milestone Jan 31, 2020
PierreRambaud
PierreRambaud previously requested changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@PierreRambaud PierreRambaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assets must be built?

@tomas862
Copy link
Contributor Author

Assets must be built?

yes added small detail to the javascript

@matks matks added the migration symfony migration project label Jan 31, 2020
@matks matks added the Waiting for QA Status: action required, waiting for test feedback label Feb 3, 2020
@tomas862 tomas862 mentioned this pull request Feb 3, 2020
Closed
@Robin-Fischer-PS Robin-Fischer-PS self-assigned this Feb 6, 2020
@Robin-Fischer-PS
Copy link
Contributor

It's QA ✔️ , thanks @tomas862 !

@Robin-Fischer-PS Robin-Fischer-PS added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 6, 2020
@PierreRambaud PierreRambaud merged commit c4d7be4 into PrestaShop:1.7.7.x Feb 6, 2020
@PierreRambaud
Copy link
Contributor

Thanks @tomas862

@boubkerbribri boubkerbribri mentioned this pull request Feb 7, 2020
Merged
@matks matks mentioned this pull request Feb 11, 2020
Open
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

Assignees

@Robin-Fischer-PS Robin-Fischer-PS

Labels
1.7.7.x Branch Improvement Type: Improvement migration symfony migration project QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.7.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tomas862 @Robin-Fischer-PS @PierreRambaud @Progi1984 @matks @prestonBot