-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paste product combination tokens and highlight invalid tokens #18095
Paste product combination tokens and highlight invalid tokens #18095
Conversation
Hello @MarkALeonard! This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community! |
Thanks for your contribution @MarkALeonard, I left some comments mainly aiming good practices :) |
Co-Authored-By: SZCZUPAK Valentin <valentin.szczupak@prestashop.com>
Co-Authored-By: SZCZUPAK Valentin <valentin.szczupak@prestashop.com>
Co-Authored-By: SZCZUPAK Valentin <valentin.szczupak@prestashop.com>
Thanks @NeOMakinG for your feedback, I have made the changes accordingly. |
Did you test it after changes ? Hope the |
Yes, tested and works as expected. Thank you. |
Imorove multiple engine search results.
On implementing on a live site I noticed the Bloodhound engine returns multiple results for 'Size : S' but not 'Size : M'. Have changed |
Co-Authored-By: Progi1984 <progi1984@gmail.com>
Co-Authored-By: SZCZUPAK Valentin <valentin.szczupak@prestashop.com>
Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
Hi @MarkALeonard, Can you please resolve conflicts. Thanks! |
LGTM Thanks @MarkALeonard |
Thanks @MarkALeonard |
This change is