Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix language used in pdf attachement sent by mail #18352

Merged
merged 5 commits into from
Apr 9, 2020

Conversation

Matt75
Copy link
Contributor

@Matt75 Matt75 commented Mar 28, 2020

Questions Answers
Branch? develop
Description? Invoice or DeliverySlip sent by mail are not using Language used for Order
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? #10258 (Partial : fixed only for PDF sent by mail)
How to test? Change OrderState to Payment accepted or change OrderState to Processing in progress, attachment PDF sent by mail use Language used in BO, not Language used in Order.

Test scenario

In FO use French language
Make an Order in french

In BO use English language
Change OrderState to Payment accepted
Mail sent to Customer have attachment in English (BO language) instead of Customer language used to make the Order.

With this change, mail attachement should be in language used by customer on FO


This change is Reviewable

@Matt75 Matt75 requested a review from a team as a code owner March 28, 2020 19:11
@prestonBot prestonBot added develop Branch Bug Type: Bug Waiting for wording Status: action required, waiting for wording labels Mar 28, 2020
@Matt75 Matt75 changed the title Fix language pdf mail Fix language used in pdf attachement sent by mail Mar 28, 2020
classes/Context.php Outdated Show resolved Hide resolved
@Matt75 Matt75 force-pushed the fix-language-pdf-mail branch 4 times, most recently from 5c86d9c to c01512f Compare March 30, 2020 08:06
@LouiseBonnard LouiseBonnard removed the Waiting for wording Status: action required, waiting for wording label Mar 30, 2020
@matthieu-rolland matthieu-rolland added the Waiting for QA Status: action required, waiting for test feedback label Mar 31, 2020
@khouloudbelguith khouloudbelguith self-assigned this Apr 9, 2020
@khouloudbelguith
Copy link
Contributor

Hi @Matt75,

I installed a shop with the "English" language and Japan country.
In the Fo, the customer language is (Japanese)

Thanks!

@khouloudbelguith khouloudbelguith added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 9, 2020
@khouloudbelguith khouloudbelguith added this to the 1.7.8.0 milestone Apr 9, 2020
@Progi1984 Progi1984 merged commit 3481603 into PrestaShop:develop Apr 9, 2020
@Progi1984
Copy link
Member

Thanks @Matt75

@superskyman100
Copy link

This code works only with your configuration. We tried with PS 1.7.6.4 it's not working, the files are different.

@Matt75
Copy link
Contributor Author

Matt75 commented Jun 14, 2020

@superskyman100 This change is only for 1.7.8 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants