Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional test - Fix Sql queries tests #19268

Merged
merged 1 commit into from
May 25, 2020
Merged

Functional test - Fix Sql queries tests #19268

merged 1 commit into from
May 25, 2020

Conversation

boubkerbribri
Copy link
Contributor

@boubkerbribri boubkerbribri commented May 22, 2020 •
edited
Loading

Questions Answers
Branch? develop
Description? Fix Sql queries tests, add modal to confirm delete within a row
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? TEST_PATH="functional/BO/14_advancedParameters/07_database/sqlManager" URL_FO=shopUrl/ npm run specific-test

This change is Reviewable

@boubkerbribri boubkerbribri added the TE Category: Tests label May 22, 2020
@boubkerbribri boubkerbribri added this to the 1.7.8.0 milestone May 22, 2020
@boubkerbribri boubkerbribri requested a review from a team as a code owner May 22, 2020 09:21
@prestonBot prestonBot added 1.7.7.x Branch Refactoring Type: Refactoring develop Branch labels May 22, 2020
@boubkerbribri boubkerbribri removed the 1.7.7.x Branch label May 22, 2020
@Progi1984 Progi1984 added the QA ✔️ Status: check done, code approved label May 22, 2020
@SimonGrn SimonGrn merged commit ac0010b into PrestaShop:develop May 25, 2020
@prestashop-issue-bot prestashop-issue-bot bot added the Fixed Resolution: issue closed because fixed label May 25, 2020
@boubkerbribri boubkerbribri deleted the Delete-modal-sql-query branch May 12, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

Assignees
No one assigned
Labels
develop Branch Fixed Resolution: issue closed because fixed QA ✔️ Status: check done, code approved Refactoring Type: Refactoring TE Category: Tests
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@boubkerbribri @PierreRambaud @Progi1984 @prestonBot @SimonGrn