Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the German tax rates #19709

Merged
merged 3 commits into from
Jun 22, 2020
Merged

Update the German tax rates #19709

merged 3 commits into from
Jun 22, 2020

Conversation

LouiseBonnard
Copy link
Contributor

@LouiseBonnard LouiseBonnard commented Jun 11, 2020 •
edited by eternoendless
Loading

Questions Answers
Branch? develop - sorry, could not succeed in creating this PR on the 1.7.7.x branch
Description? Update the German tax rates following Angela Merkel's announcement
Type? improvement
Category? LO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #19628
How to test? Install the German pack, check that tax rates are 16% instead of 19% and 5% instead of 7%.

This change is Reviewable

@LouiseBonnard LouiseBonnard requested a review from a team as a code owner June 11, 2020 07:03
@prestonBot prestonBot added the Improvement Type: Improvement label Jun 11, 2020
@LouiseBonnard LouiseBonnard added LO Category: Localization Localization Label: Which BO under menu is concerned labels Jun 11, 2020
@LouiseBonnard LouiseBonnard mentioned this pull request Jun 11, 2020
Merged
Progi1984
Progi1984 previously approved these changes Jun 11, 2020
View reviewed changes
@Progi1984 Progi1984 requested a review from a team June 11, 2020 12:26
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Jun 11, 2020
@Progi1984 Progi1984 changed the base branch from develop to 1.7.7.x June 11, 2020 13:09
@Progi1984 Progi1984 dismissed their stale review June 11, 2020 13:09

The base branch was changed.

@Progi1984 Progi1984 changed the base branch from 1.7.7.x to develop June 11, 2020 13:10
Progi1984
Progi1984 previously approved these changes Jun 11, 2020
View reviewed changes
PierreRambaud
PierreRambaud previously approved these changes Jun 11, 2020
View reviewed changes
@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Jun 12, 2020
@colinegin colinegin modified the milestones: 1.7.8.0, 1.7.7.0 Jun 22, 2020
@eternoendless
Copy link
Member

@LouiseBonnard you forgot to create your PR from an independent branch. Since you did it from your develop branch you will have a hard time rebasing it.

@Progi1984
Copy link
Member

Validated by @Robin-Fischer-PS . Thanks :)

@colinegin colinegin added the 1.7.7.x Branch label Jun 22, 2020
@Progi1984 Progi1984 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 22, 2020
@prestashop-issue-bot
Copy link

QA OK without required approvals !? :trollface:

@matks
Copy link
Contributor

matks commented Jun 22, 2020

Thank you @LouiseBonnard

@matks matks merged commit dd53152 into PrestaShop:develop Jun 22, 2020
@Progi1984 Progi1984 mentioned this pull request Jun 22, 2020
Merged
@eternoendless eternoendless modified the milestones: 1.7.7.0, 1.7.8.0 Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Progi1984 approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@matks matks matks approved these changes

@PierreRambaud PierreRambaud PierreRambaud left review comments

Assignees
No one assigned
Labels
1.7.7.x Branch Improvement Type: Improvement LO Category: Localization Localization Label: Which BO under menu is concerned QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.8.0
Development

Successfully merging this pull request may close these issues.

Update the German tax rates
8 participants
@LouiseBonnard @eternoendless @Progi1984 @matks @PierreRambaud @matthieu-rolland @prestonBot @colinegin